Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to brute force for hnsw when topk is super large #219

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

chasingegg
Copy link
Collaborator

@chasingegg chasingegg commented Nov 27, 2023

Fix #218, Set threshold to 0.5 for safety.
image
image

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

mergify bot commented Nov 27, 2023

@chasingegg 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@chasingegg
Copy link
Collaborator Author

/kind improvement

@foxspy
Copy link
Collaborator

foxspy commented Nov 27, 2023

/lgtm

@sre-ci-robot sre-ci-robot merged commit aeb6931 into zilliztech:main Nov 27, 2023
7 checks passed
@chasingegg chasingegg deleted the switch-bf branch November 27, 2023 11:00
chasingegg added a commit to chasingegg/Knowhere that referenced this pull request Dec 6, 2023
sre-ci-robot pushed a commit that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] switch to BF for hnsw when topk is super large
3 participants