Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default IVF_PQ build param m to 32 #236

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

cydrain
Copy link
Collaborator

@cydrain cydrain commented Nov 30, 2023

No description provided.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

mergify bot commented Nov 30, 2023

@cydrain 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@cydrain
Copy link
Collaborator Author

cydrain commented Nov 30, 2023

/kind improvement

@alexanderguzhva
Copy link
Collaborator

/lgtm

@liliu-z
Copy link
Collaborator

liliu-z commented Dec 6, 2023

@cydrain Plz rerun the e2e test and cp this PR to 2.2 branch

@cydrain cydrain force-pushed the caiyd_update_default_pq_m branch from a43a5d8 to f2b154d Compare December 7, 2023 02:09
@sre-ci-robot sre-ci-robot removed the lgtm label Dec 7, 2023
@cqy123456
Copy link
Collaborator

/lgtm

@mergify mergify bot added the ci-passed label Dec 7, 2023
@sre-ci-robot sre-ci-robot merged commit 689282a into zilliztech:main Dec 7, 2023
9 checks passed
@cydrain cydrain deleted the caiyd_update_default_pq_m branch December 7, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants