Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flush raft results ids #239

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

Presburger
Copy link
Collaborator

/kind bug
/issue: #227

Signed-off-by: Yusheng.Ma <[email protected]>
@Presburger
Copy link
Collaborator Author

@wphicks HI, "I'm temporarily aligning invalid IDs to -1 to adapt to the processing logic in the upper layers of Milvus. Do you have any suggestions?

Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! This is a fine workaround for the moment, and we'll get a proper fix in upstream to avoid the extra device allocation.

Copy link
Collaborator

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy, Presburger, wphicks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 47349d9 into zilliztech:main Dec 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants