fix: diskann hang out in release function #241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cqy123456 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cqy123456
changed the title
liliu-z
reviewed
Dec 1, 2023
| @@ -307,6 +307,7 @@ namespace diskann { | |||
| std::string sample_bin, _u64 l_search, _u64 beamwidth, | |||
| _u64 num_nodes_to_cache) { | |||
| #endif | |||
| this->async_generate_cache.store(true); | |||
There was a problem hiding this comment.
If it is false during the destruction check, and then do cache gen, crash will occur.
cqy123456
force-pushed
the
async_fix
branch
2 times, most recently
from
5d6e9a1 to
1c4a996
Compare
Signed-off-by: cqy123456 <[email protected]>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.