Always require change branch #115
zancasci.yml
on: pull_request
Bitrot check
3m 2s
Clippy (MSRV)
3m 5s
Clippy (beta)
10s
Code coverage
10m 6s
Intra-doc links
3m 29s
Rustfmt
14s
protobuf consistency
2m 51s
UUID validity
8s
Matrix: build-latest
Matrix: build-nodefault
Matrix: check-msrv
Matrix: test
Annotations
60 errors and 5 warnings
|
Clippy (beta)
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
|
|
Build target wasm32-wasi
Process completed with exit code 101.
|
|
unused variable: `utxos_spent`:
zcash_client_backend/src/data_api/wallet.rs#L809
error: unused variable: `utxos_spent`
--> zcash_client_backend/src/data_api/wallet.rs:809:9
|
809 | let utxos_spent = {
| ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_utxos_spent`
|
|
unused variable: `proposal`:
zcash_client_backend/src/data_api/wallet.rs#L593
error: unused variable: `proposal`
--> zcash_client_backend/src/data_api/wallet.rs:593:5
|
593 | proposal: &Proposal<FeeRuleT, N>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_proposal`
|
|
unused variable: `ovk_policy`:
zcash_client_backend/src/data_api/wallet.rs#L592
error: unused variable: `ovk_policy`
--> zcash_client_backend/src/data_api/wallet.rs:592:5
|
592 | ovk_policy: OvkPolicy,
| ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_ovk_policy`
|
|
unused variable: `usk`:
zcash_client_backend/src/data_api/wallet.rs#L591
error: unused variable: `usk`
--> zcash_client_backend/src/data_api/wallet.rs:591:5
|
591 | usk: &UnifiedSpendingKey,
| ^^^ help: if this is intentional, prefix it with an underscore: `_usk`
|
|
unused variable: `output_prover`:
zcash_client_backend/src/data_api/wallet.rs#L590
error: unused variable: `output_prover`
--> zcash_client_backend/src/data_api/wallet.rs:590:5
|
590 | output_prover: &impl OutputProver,
| ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_output_prover`
|
|
unused variable: `spend_prover`:
zcash_client_backend/src/data_api/wallet.rs#L589
error: unused variable: `spend_prover`
--> zcash_client_backend/src/data_api/wallet.rs:589:5
|
589 | spend_prover: &impl SpendProver,
| ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_spend_prover`
|
|
unused variable: `params`:
zcash_client_backend/src/data_api/wallet.rs#L588
error: unused variable: `params`
--> zcash_client_backend/src/data_api/wallet.rs:588:5
|
588 | params: &ParamsT,
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_params`
|
|
unused variable: `wallet_db`:
zcash_client_backend/src/data_api/wallet.rs#L587
error: unused variable: `wallet_db`
--> zcash_client_backend/src/data_api/wallet.rs:587:5
|
587 | wallet_db: &mut DbT,
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_wallet_db`
|
= note: `-D unused-variables` implied by `-D warnings`
|
|
unreachable statement:
zcash_client_backend/src/data_api/wallet.rs#L609
error: unreachable statement
--> zcash_client_backend/src/data_api/wallet.rs:609:5
|
608 | unimplemented!();
| ---------------- any code following this expression is unreachable
609 | let mut step_results = Vec::with_capacity(proposal.steps().len());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement
|
= note: `-D unreachable-code` implied by `-D warnings`
|
|
unused variable: `utxos_spent`:
zcash_client_backend/src/data_api/wallet.rs#L809
error: unused variable: `utxos_spent`
--> zcash_client_backend/src/data_api/wallet.rs:809:9
|
809 | let utxos_spent = {
| ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_utxos_spent`
|
|
unused variable: `proposal`:
zcash_client_backend/src/data_api/wallet.rs#L593
error: unused variable: `proposal`
--> zcash_client_backend/src/data_api/wallet.rs:593:5
|
593 | proposal: &Proposal<FeeRuleT, N>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_proposal`
|
|
unused variable: `ovk_policy`:
zcash_client_backend/src/data_api/wallet.rs#L592
error: unused variable: `ovk_policy`
--> zcash_client_backend/src/data_api/wallet.rs:592:5
|
592 | ovk_policy: OvkPolicy,
| ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_ovk_policy`
|
|
unused variable: `usk`:
zcash_client_backend/src/data_api/wallet.rs#L591
error: unused variable: `usk`
--> zcash_client_backend/src/data_api/wallet.rs:591:5
|
591 | usk: &UnifiedSpendingKey,
| ^^^ help: if this is intentional, prefix it with an underscore: `_usk`
|
|
unused variable: `output_prover`:
zcash_client_backend/src/data_api/wallet.rs#L590
error: unused variable: `output_prover`
--> zcash_client_backend/src/data_api/wallet.rs:590:5
|
590 | output_prover: &impl OutputProver,
| ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_output_prover`
|
|
unused variable: `spend_prover`:
zcash_client_backend/src/data_api/wallet.rs#L589
error: unused variable: `spend_prover`
--> zcash_client_backend/src/data_api/wallet.rs:589:5
|
589 | spend_prover: &impl SpendProver,
| ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_spend_prover`
|
|
unused variable: `params`:
zcash_client_backend/src/data_api/wallet.rs#L588
error: unused variable: `params`
--> zcash_client_backend/src/data_api/wallet.rs:588:5
|
588 | params: &ParamsT,
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_params`
|
|
unused variable: `wallet_db`:
zcash_client_backend/src/data_api/wallet.rs#L587
error: unused variable: `wallet_db`
--> zcash_client_backend/src/data_api/wallet.rs:587:5
|
587 | wallet_db: &mut DbT,
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_wallet_db`
|
= note: `-D unused-variables` implied by `-D warnings`
|
|
unreachable statement:
zcash_client_backend/src/data_api/wallet.rs#L609
error: unreachable statement
--> zcash_client_backend/src/data_api/wallet.rs:609:5
|
608 | unimplemented!();
| ---------------- any code following this expression is unreachable
609 | let mut step_results = Vec::with_capacity(proposal.steps().len());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement
|
= note: `-D unreachable-code` implied by `-D warnings`
|
|
unused import: `sapling::zip212_enforcement`:
zcash_client_backend/src/data_api/wallet.rs#L61
error: unused import: `sapling::zip212_enforcement`
--> zcash_client_backend/src/data_api/wallet.rs:61:45
|
61 | components::{amount::NonNegativeAmount, sapling::zip212_enforcement},
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused imports: `Recipient`, `SentTransactionOutput`, `SentTransaction`:
zcash_client_backend/src/data_api/wallet.rs#L48
error: unused imports: `Recipient`, `SentTransactionOutput`, `SentTransaction`
--> zcash_client_backend/src/data_api/wallet.rs:48:32
|
48 | error::Error, Account, SentTransaction, SentTransactionOutput, WalletCommitmentTrees,
| ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^
...
55 | wallet::{Note, OvkPolicy, Recipient, TransparentAddressMetadata},
| ^^^^^^^^^
|
|
unused imports: `PreparedIncomingViewingKey`, `try_sapling_note_decryption`:
zcash_client_backend/src/data_api/wallet.rs#L39
error: unused imports: `PreparedIncomingViewingKey`, `try_sapling_note_decryption`
--> zcash_client_backend/src/data_api/wallet.rs:39:23
|
39 | note_encryption::{try_sapling_note_decryption, PreparedIncomingViewingKey},
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`
|
|
unused import: `sapling::zip212_enforcement`:
zcash_client_backend/src/data_api/wallet.rs#L61
error: unused import: `sapling::zip212_enforcement`
--> zcash_client_backend/src/data_api/wallet.rs:61:45
|
61 | components::{amount::NonNegativeAmount, sapling::zip212_enforcement},
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused imports: `Recipient`, `SentTransactionOutput`, `SentTransaction`:
zcash_client_backend/src/data_api/wallet.rs#L48
error: unused imports: `Recipient`, `SentTransactionOutput`, `SentTransaction`
--> zcash_client_backend/src/data_api/wallet.rs:48:32
|
48 | error::Error, Account, SentTransaction, SentTransactionOutput, WalletCommitmentTrees,
| ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^
...
55 | wallet::{Note, OvkPolicy, Recipient, TransparentAddressMetadata},
| ^^^^^^^^^
|
|
unused imports: `PreparedIncomingViewingKey`, `try_sapling_note_decryption`:
zcash_client_backend/src/data_api/wallet.rs#L39
error: unused imports: `PreparedIncomingViewingKey`, `try_sapling_note_decryption`
--> zcash_client_backend/src/data_api/wallet.rs:39:23
|
39 | note_encryption::{try_sapling_note_decryption, PreparedIncomingViewingKey},
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`
|
|
Clippy (MSRV)
Clippy had exited with the 101 exit code
|
|
Code coverage
Process completed with exit code 1.
|
|
Test Orchard on macOS
Process completed with exit code 101.
|
|
Test on macOS
Process completed with exit code 101.
|
|
Test on Windows
The job was canceled because "macOS_NOT_A_PUZZLE" failed.
|
|
Test on Linux
The job was canceled because "macOS_NOT_A_PUZZLE" failed.
|
|
Test NU6 on Windows
The job was canceled because "macOS_NOT_A_PUZZLE" failed.
|
|
Test NU6 on Linux
The job was canceled because "macOS_NOT_A_PUZZLE" failed.
|
|
Test Orchard on Linux
The job was canceled because "macOS_NOT_A_PUZZLE" failed.
|
|
Test Orchard on Windows
The job was canceled because "macOS_NOT_A_PUZZLE" failed.
|
|
unused variable: `utxos_spent`:
zcash_client_backend/src/data_api/wallet.rs#L809
error: unused variable: `utxos_spent`
--> zcash_client_backend/src/data_api/wallet.rs:809:9
|
809 | let utxos_spent = {
| ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_utxos_spent`
|
|
unused variable: `proposal`:
zcash_client_backend/src/data_api/wallet.rs#L593
error: unused variable: `proposal`
--> zcash_client_backend/src/data_api/wallet.rs:593:5
|
593 | proposal: &Proposal<FeeRuleT, N>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_proposal`
|
|
unused variable: `ovk_policy`:
zcash_client_backend/src/data_api/wallet.rs#L592
error: unused variable: `ovk_policy`
--> zcash_client_backend/src/data_api/wallet.rs:592:5
|
592 | ovk_policy: OvkPolicy,
| ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_ovk_policy`
|
|
unused variable: `usk`:
zcash_client_backend/src/data_api/wallet.rs#L591
error: unused variable: `usk`
--> zcash_client_backend/src/data_api/wallet.rs:591:5
|
591 | usk: &UnifiedSpendingKey,
| ^^^ help: if this is intentional, prefix it with an underscore: `_usk`
|
|
unused variable: `output_prover`:
zcash_client_backend/src/data_api/wallet.rs#L590
error: unused variable: `output_prover`
--> zcash_client_backend/src/data_api/wallet.rs:590:5
|
590 | output_prover: &impl OutputProver,
| ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_output_prover`
|
|
unused variable: `spend_prover`:
zcash_client_backend/src/data_api/wallet.rs#L589
error: unused variable: `spend_prover`
--> zcash_client_backend/src/data_api/wallet.rs:589:5
|
589 | spend_prover: &impl SpendProver,
| ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_spend_prover`
|
|
unused variable: `params`:
zcash_client_backend/src/data_api/wallet.rs#L588
error: unused variable: `params`
--> zcash_client_backend/src/data_api/wallet.rs:588:5
|
588 | params: &ParamsT,
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_params`
|
|
unused variable: `wallet_db`:
zcash_client_backend/src/data_api/wallet.rs#L587
error: unused variable: `wallet_db`
--> zcash_client_backend/src/data_api/wallet.rs:587:5
|
587 | wallet_db: &mut DbT,
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_wallet_db`
|
= note: `-D unused-variables` implied by `-D warnings`
|
|
unused variable: `utxos_spent`:
zcash_client_backend/src/data_api/wallet.rs#L809
error: unused variable: `utxos_spent`
--> zcash_client_backend/src/data_api/wallet.rs:809:9
|
809 | let utxos_spent = {
| ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_utxos_spent`
|
|
unused variable: `proposal`:
zcash_client_backend/src/data_api/wallet.rs#L593
error: unused variable: `proposal`
--> zcash_client_backend/src/data_api/wallet.rs:593:5
|
593 | proposal: &Proposal<FeeRuleT, N>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_proposal`
|
|
unused variable: `ovk_policy`:
zcash_client_backend/src/data_api/wallet.rs#L592
error: unused variable: `ovk_policy`
--> zcash_client_backend/src/data_api/wallet.rs:592:5
|
592 | ovk_policy: OvkPolicy,
| ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_ovk_policy`
|
|
unused variable: `usk`:
zcash_client_backend/src/data_api/wallet.rs#L591
error: unused variable: `usk`
--> zcash_client_backend/src/data_api/wallet.rs:591:5
|
591 | usk: &UnifiedSpendingKey,
| ^^^ help: if this is intentional, prefix it with an underscore: `_usk`
|
|
unused variable: `output_prover`:
zcash_client_backend/src/data_api/wallet.rs#L590
error: unused variable: `output_prover`
--> zcash_client_backend/src/data_api/wallet.rs:590:5
|
590 | output_prover: &impl OutputProver,
| ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_output_prover`
|
|
unused variable: `spend_prover`:
zcash_client_backend/src/data_api/wallet.rs#L589
error: unused variable: `spend_prover`
--> zcash_client_backend/src/data_api/wallet.rs:589:5
|
589 | spend_prover: &impl SpendProver,
| ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_spend_prover`
|
|
unused variable: `params`:
zcash_client_backend/src/data_api/wallet.rs#L588
error: unused variable: `params`
--> zcash_client_backend/src/data_api/wallet.rs:588:5
|
588 | params: &ParamsT,
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_params`
|
|
unused variable: `wallet_db`:
zcash_client_backend/src/data_api/wallet.rs#L587
error: unused variable: `wallet_db`
--> zcash_client_backend/src/data_api/wallet.rs:587:5
|
587 | wallet_db: &mut DbT,
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_wallet_db`
|
= note: `-D unused-variables` implied by `-D warnings`
|
|
unreachable statement:
zcash_client_backend/src/data_api/wallet.rs#L609
error: unreachable statement
--> zcash_client_backend/src/data_api/wallet.rs:609:5
|
608 | unimplemented!();
| ---------------- any code following this expression is unreachable
609 | let mut step_results = Vec::with_capacity(proposal.steps().len());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement
|
= note: `-D unreachable-code` implied by `-D warnings`
|
|
unreachable statement:
zcash_client_backend/src/data_api/wallet.rs#L609
error: unreachable statement
--> zcash_client_backend/src/data_api/wallet.rs:609:5
|
608 | unimplemented!();
| ---------------- any code following this expression is unreachable
609 | let mut step_results = Vec::with_capacity(proposal.steps().len());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement
|
= note: `-D unreachable-code` implied by `-D warnings`
|
|
unused import: `sapling::zip212_enforcement`:
zcash_client_backend/src/data_api/wallet.rs#L61
error: unused import: `sapling::zip212_enforcement`
--> zcash_client_backend/src/data_api/wallet.rs:61:45
|
61 | components::{amount::NonNegativeAmount, sapling::zip212_enforcement},
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused imports: `Recipient`, `SentTransactionOutput`, `SentTransaction`:
zcash_client_backend/src/data_api/wallet.rs#L48
error: unused imports: `Recipient`, `SentTransactionOutput`, `SentTransaction`
--> zcash_client_backend/src/data_api/wallet.rs:48:32
|
48 | error::Error, Account, SentTransaction, SentTransactionOutput, WalletCommitmentTrees,
| ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^
...
55 | wallet::{Note, OvkPolicy, Recipient, TransparentAddressMetadata},
| ^^^^^^^^^
|
|
unused imports: `PreparedIncomingViewingKey`, `try_sapling_note_decryption`:
zcash_client_backend/src/data_api/wallet.rs#L39
error: unused imports: `PreparedIncomingViewingKey`, `try_sapling_note_decryption`
--> zcash_client_backend/src/data_api/wallet.rs:39:23
|
39 | note_encryption::{try_sapling_note_decryption, PreparedIncomingViewingKey},
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`
|
|
unused import: `sapling::zip212_enforcement`:
zcash_client_backend/src/data_api/wallet.rs#L61
error: unused import: `sapling::zip212_enforcement`
--> zcash_client_backend/src/data_api/wallet.rs:61:45
|
61 | components::{amount::NonNegativeAmount, sapling::zip212_enforcement},
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused imports: `Recipient`, `SentTransactionOutput`, `SentTransaction`:
zcash_client_backend/src/data_api/wallet.rs#L48
error: unused imports: `Recipient`, `SentTransactionOutput`, `SentTransaction`
--> zcash_client_backend/src/data_api/wallet.rs:48:32
|
48 | error::Error, Account, SentTransaction, SentTransactionOutput, WalletCommitmentTrees,
| ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^
...
55 | wallet::{Note, OvkPolicy, Recipient, TransparentAddressMetadata},
| ^^^^^^^^^
|
|
unused imports: `PreparedIncomingViewingKey`, `try_sapling_note_decryption`:
zcash_client_backend/src/data_api/wallet.rs#L39
error: unused imports: `PreparedIncomingViewingKey`, `try_sapling_note_decryption`
--> zcash_client_backend/src/data_api/wallet.rs:39:23
|
39 | note_encryption::{try_sapling_note_decryption, PreparedIncomingViewingKey},
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`
|
|
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Clippy (beta)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
protobuf consistency
The following actions uses Node.js version which is deprecated and will be forced to run on node20: supplypike/setup-bin@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Clippy (MSRV)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Clippy (MSRV)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|