Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add un ser unittests #10

Open
wants to merge 154 commits into
base: master
Choose a base branch
from
Open

Add un ser unittests #10

wants to merge 154 commits into from

Conversation

zancas
Copy link
Member

@zancas zancas commented Nov 9, 2021

No description provided.

luke-jr and others added 30 commits October 28, 2021 10:31
@luke-jr @zancas
Combine common error strings for different options so translations ca…
c1201dc 
…n be shared and reused

(cherry picked from commit 5e10922)
@theuni @zancas
net: require lookup functions to specify all arguments
7cca797 
To make it clear where DNS resolves are happening

(cherry picked from commit e9fc71e)
@theuni @zancas
net: manually resolve dns seed sources
f7e7659 
Note: Some seeds aren't actually returning an IP for their name entries, so
they're being added to addrman with a source of [::].

This commit shouldn't change that behavior, for better or worse.

(cherry picked from commit a98cd1f)
@theuni @zancas
net: resolve outside of storage structures
15c30d7 
Rather than allowing CNetAddr/CService/CSubNet to launch DNS queries, require
that addresses are already resolved.

This greatly simplifies async resolve logic, and makes it harder to
accidentally leak DNS queries.

(cherry picked from commit 3675699)
@theuni @zancas
net: disable resolving from storage structures
0cee429 
CNetAddr/CService/CSubnet can no longer resolve DNS.

(cherry picked from commit d39f5b4)
@sipa @zancas
Introduce enum ServiceFlags for service flags
55708f5 
(cherry picked from commit ee06e04)
@zancas
fix GetAdjustedTime reversion, and pass NODE_NONE to CAddress
6c1454b
@zancas
remove SetServices
8cf62ae
@zancas
Revert changes from CserviceFlags cherry-pick to prefer zcash logic a…
ba1d17d 
…round use of nServices
@zancas
pass NODE_NONE as a second arg where ommitted
6e1a9c6
@zancas
revert unnecessary changes pulled in with the addition of ServiceFlags
bb8a1af
@AloeareV @zancas
Removed extranious lines
16774a6
@theuni @zancas
net: Split resolving out of CNetAddr
b6649b2 
(cherry picked from commit 31d6b1d)
@theuni @zancas
net: Split resolving out of CService
634738e 
(cherry picked from commit f96c7c4)
@zancas
copy static helper from addrman_tests.cpp
b7c6cba
@theuni @zancas
net: Split resolving out of CSubNet
0bfe4c5 
(cherry picked from commit b6c3ff3)
@theuni @zancas
net: Add direct tests for new CSubNet constructors
7095826 
(cherry picked from commit 1017b8a)
@theuni @zancas
net: move CNetAddr/CService/CSubNet out of netbase
82064de 
(cherry picked from commit 21e5b96)
@zancas
revert incorrect change to SerializationOp calls
0b021bc
@theuni @zancas
net: narrow include scope after moving to netaddress
4ffb715 
Net functionality is no longer needed for CAddress/CAddrman/etc. now that
CNetAddr/CService/CSubNet are dumb storage classes.

(cherry picked from commit 21ba407)
@zancas
explicitly include netbase.h in gtests
46625fb
@theuni @zancas
net: Have LookupNumeric return a CService directly
8cdc833 
Also fix up a few small issues:
- Lookup with "badip:port" now sets the port to 0
- Don't allow assert to have side-effects

(cherry picked from commit 8945384)
@theuni @zancas
net: fixup nits
68e39cd 
(cherry picked from commit 9e9d644)
@vasild @zancas
test: add two edge case tests for CSubNet
aefb74a 
(cherry picked from commit ccef5d7)
@zancas
scripted-diff: Replace NET_TOR with NET_ONION
8d1f697 
-BEGIN VERIFY SCRIPT-

sed --in-place'' --expression='s/NET_TOR/NET_ONION/g' $(git grep -I --files-with-matches 'NET_TOR')

-END VERIFY SCRIPT-

The --in-place'' hack is required for sed on macOS to edit files in-place without passing a backup extension.

(cherry picked from commit 07c493f)
@zancas
backport single-line definition of GetAddrBytes
b8a1835 
( cherry-plucked from: b691f2d )

In github context:

bitcoin/bitcoin@b691f2d#diff-9281caf81406a5c4e11f572f613a4cc9769f39c66579ed75a4c957f30b39d836
@vasild @zancas
net: improve encapsulation of CNetAddr
a824fbc 
Do not access `CNetAddr::ip` directly from `CService` methods.

This improvement will help later when we change the type of
`CNetAddr::ip` (in the BIP155 implementation).

Co-authored-by: Carl Dong <[email protected]>
(cherry picked from commit bc74a40)
@vasild @zancas
net: document enum Network
498ef00 
(cherry picked from commit 100c64a)
@theuni @zancas
net: add an internal subnet for representing unresolved hostnames
13b1b17 
We currently do two resolves for dns seeds: one for the results, and one to
serve in addrman as the source for those addresses.

There's no requirement that the source hostname resolves to the stored
identifier, only that the mapping is unique. So rather than incurring the
second lookup, combine a private subnet with a hash of the hostname.

The resulting v6 ip is guaranteed not to be publicy routable, and has only a
negligible chance of colliding with a user's internal network (which would be
of no consequence anyway).

(cherry picked from commit 7f31762)
@vasild @zancas
net: document enum Network
69d417a 
(cherry picked from commit 100c64a)
zancas and others added 11 commits October 28, 2021 10:31
@zancas
reinsert void Init for CAddress
ca67de1
@zancas
remove unused constructors and conflict marker
7473b8f
@zancas
remove unsupported service types from tests
b2ea131 
(cherry picked from commit 27d53eb)
@zancas
correct test vector counts
726029a 
(cherry picked from commit 5c34bff)
@theuni @zancas
net: add CVectorWriter and CNetMsgMaker
842e727 
CVectorWriter is useful for overwriting or appending an existing byte vector.

CNetMsgMaker is a shortcut for creating messages on-the-fly which are suitable
for pushing to CConnman.

(cherry picked from commit 2ec935d)
(cherry picked from commit 878e63c)
@zancas
minimal changes to net.h and net_processing.cpp
6a97885 
minimally change net_processing by adding "addrv2" as a strCommand
minimally change net.h with addition of m_wants_addrv2

(cherry picked from commit 353a3fd)
(cherry picked from commit d2d5557)
@zancas
minimal changes to net.h and netaddress.{h,cpp}
ef9322e 
 (cherry picked from commit 353a3fd)

(cherry picked from commit 19ee7cf)
@zancas
update torcontrol.cpp
22a18dd 
  (cherry picked from commit dcf0cb4)

(cherry picked from commit 796c30a)
@zancas
remove unused include
b97dfd7
@zancas
scripted replacement of BIP155 with ZIP155
b5f4da8
@zancas
add unittests of SER_NETWORK [Un]serializtion of message(s)
9ee66e4
zancas and others added 17 commits November 9, 2021 13:17
@zancas
drop LogPrintfs into addrman.h
f37e6e9
@vasild @zancas
net: advertise support for ADDRv2 via new message
46fb77e 
Introduce a new message `sendaddrv2` to signal support for ADDRv2.
Send the new message immediately after sending the `VERACK` message.

Add support for receiving and parsing ADDRv2 messages.

Send ADDRv2 messages (instead of ADDR) to a peer if he has
advertised support for it.

Co-authored-by: Carl Dong <[email protected]>
(cherry picked from commit 353a3fd)
@zancas
begin defining addrv2 addrdb test
5a49fd8
@zancas
wip new test in net_tests, rm'd some funny code
6535c8e
@zancas
wip reactivate test and introspect test serialized datastream
48bb561
@zancas
wip reactivate test and introspect test serialized datastream
5653867
@zancas
hack on serialization test
6ef2d0f
@zancas
rm incorrect comment, note other incorrect, begin test of deserializi…
7670fb2 
…ng torv3 to addrdb
@zancas
add sanity check or tv3 ADD, serialize, unserialize, and start with m…
df94812 
…ock CAddrDB
@zancas
add read_from_protocol_v1
a6bdfec
@zancas
make test file a default parameter to the mock method
20f2d87
@zancas
remove default
e593e36
@zancas
rm LogPrintfs, change serialization format numbering, comment out exp…
5fb7f2b 
…ected BOOST fails
@zancas
remove debug statements
8c70dc8
@zancas
remove debug from net.cpp
7380394
@zancas
Logging InterruptibleRecv context
8b1bf1c
@zancas
begin unit test of socks5 functionality
b23ffdc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.