Reply to only orchard ua #765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: The App uses the full UA from the wallet inside of the memo just after the
Reply-to:feature, and this is not the best idea, leaking info about the transparent address.After: The App uses the only-orchard UA from the wallet for the same propose. Here there is no leaking info at all.
Use Cases: The user have a contact already with a full UA or simply the user wants to add a contact with their full UA.
Solution: The App generate the only-orchard UA for both cases, storing both addresses so the App can identify the old memos (full UA) and new memos (only-orchard UA) from the same contact. We will encourage to the user to replace the full UA for the only-orchard UA for new contacts.