fix(client): prevent double serialization of operations for websockets

The commit resolves an issue where operations for websockets were being serialized twice when using the "graphql-transport-ws" protocol. This fix removes the redundant serialization step, aligning the process with expected behavior and improving efficiency.
zino-hofmann · Nov 23, 2023 · 8b9a2b2 · 8b9a2b2
1 parent baf555e
commit 8b9a2b2
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/packages/graphql/lib/src/links/websocket_link/websocket_client.dart b/packages/graphql/lib/src/links/websocket_link/websocket_client.dart
@@ -576,15 +576,17 @@ class SocketClient {
             .listen((message) => response.addError(message));
 
         if (!_subscriptionInitializers[id]!.hasBeenTriggered) {
-          GraphQLSocketMessage operation = StartOperation(
-            id,
-            serialize(payload),
-          );
+          GraphQLSocketMessage operation;
           if (protocol == GraphQLProtocol.graphqlTransportWs) {
             operation = SubscribeOperation(
               id,
               serialize(payload),
             );
+          } else {
+            operation = StartOperation(
+              id,
+              serialize(payload),
+            );
           }
           _write(operation);
           _subscriptionInitializers[id]!.hasBeenTriggered = true;