Remove legacy TokenAnalyser

.github/workflows/build.yml

@@ -38,8 +38,3 @@ jobs:
 
       - name: PHPUnit Tests
         run: bin/phpunit --configuration phpunit.xml.dist --coverage-text
-
-      - name: PHPUnit Legacy Tests
-        run: bin/phpunit --configuration phpunit.xml.dist --coverage-text
-        env:
-          PHPUNIT_ANALYSER: 'legacy'

README.md

@@ -98,9 +98,6 @@ The `openapi` command line interface can be used to generate the documentation t
 ```shell
 ./vendor/bin/openapi --help
 ```
-Starting with version 4 the default analyser used on the command line is the new `ReflectionAnalyser`.
-
-Using the `--legacy` flag (`-l`) the legacy `TokenAnalyser` can still be used.
 
 ### Usage from the Deserializer
 

bin/openapi

@@ -4,7 +4,6 @@
 use OpenApi\Analysers\AttributeAnnotationFactory;
 use OpenApi\Analysers\DocBlockAnnotationFactory;
 use OpenApi\Analysers\ReflectionAnalyser;
-use OpenApi\Analysers\TokenAnalyser;
 use OpenApi\Annotations\OpenApi;
 use OpenApi\Generator;
 use OpenApi\Util;
@@ -23,7 +22,6 @@ error_reporting(E_ALL);
 // Possible options and their default values.
 $options = [
     'config' => [],
-    'legacy' => false,
     'output' => false,
     'format' => 'auto',
     'exclude' => [],
@@ -36,7 +34,6 @@ $options = [
 ];
 $aliases = [
     'c' => 'config',
-    'l' => 'legacy',
     'o' => 'output',
     'e' => 'exclude',
     'n' => 'pattern',
@@ -132,7 +129,6 @@ Usage: openapi [--option value] [/path/to/project ...]
 Options:
   --config (-c)     Generator config
                     ex: -c operationId.hash=false
-  --legacy (-l)     Use legacy TokenAnalyser; default is the new ReflectionAnalyser
   --output (-o)     Path to store the generated documentation.
                     ex: --output openapi.yaml
   --exclude (-e)    Exclude path(s).
@@ -222,9 +218,7 @@ foreach ($options["processor"] as $processor) {
     $generator->getProcessorPipeline()->add($processor);
 }
 
-$analyser = $options['legacy']
-    ? new TokenAnalyser()
-    : new ReflectionAnalyser([new DocBlockAnnotationFactory(), new AttributeAnnotationFactory()]);
+$analyser = new ReflectionAnalyser([new DocBlockAnnotationFactory(), new AttributeAnnotationFactory()]);
 
 $openapi = $generator
     ->setVersion($options['version'])

composer.json

@@ -86,9 +86,7 @@
         "cs": "Fix all codestyle issues",
         "rector": "Automatic refactoring",
         "lint": "Test codestyle",
-        "test": "Run all non-legacy and codestyle tests",
-        "testlegacy": "Run tests using the legacy TokenAnalyser",
-        "testall": "Run all tests (test + testlegacy)",
+        "test": "Run all PHP, codestyle and rector tests",
         "analyse": "Run static analysis (phpstan/psalm)",
         "spectral-examples": "Run spectral lint over all .yaml files in the Examples folder",
         "spectral-scratch": "Run spectral lint over all .yaml files in the tests/Fixtures/Scratch folder",
@@ -108,11 +106,6 @@
             "export XDEBUG_MODE=off && phpunit",
             "@lint"
         ],
-        "testlegacy": "export XDEBUG_MODE=off && export PHPUNIT_ANALYSER=legacy && phpunit",
-        "testall": [
-            "@test",
-            "@testlegacy"
-        ],
         "analyse": [
             "export XDEBUG_MODE=off && phpstan analyse --memory-limit=2G",
             "export XDEBUG_MODE=off && psalm"

docs/guide/generating-openapi-documents.md

@@ -36,7 +36,6 @@ Usage: openapi [--option value] [/path/to/project ...]
 Options:
   --config (-c)     Generator config
                     ex: -c operationId.hash=false
-  --legacy (-l)     Use legacy TokenAnalyser; default is the new ReflectionAnalyser
   --output (-o)     Path to store the generated documentation.
                     ex: --output openapi.yaml
   --exclude (-e)    Exclude path(s).

docs/guide/under-the-hood.md

@@ -5,6 +5,7 @@
 - The `Generator` iterates over the given sources (Symfony `Finder`, file/directory list, etc)
 - The configured analyser (`AnalyserInterface`) reads the files and builds an `Analysis` object.
   Default (as of v4) is the `ReflectionAnalyser`. Alternatively, there is the `TokenAnalyser` which was the default in v3.
+- The legacy `TokenAnalyser` was removed in v5.
 - The `Analysis` object and its annotations are then processed by the configured processors.
 - If enabled, the analysis/annotations are validated.
 - The root `OpenApi` annotation then contains all annotations and is serialized into YAML/JSON.

rector.php

@@ -18,9 +18,6 @@
     ->withSkip([
         CombineIfRector::class,
         ExplicitBoolCompareRector::class,
-        ExplicitReturnNullRector::class => [
-            __DIR__ . '/src/Analysers/TokenAnalyser.php',
-        ],
         ForRepeatedCountToOwnVariableRector::class,
         RemoveAlwaysTrueIfConditionRector::class => [
             __DIR__ . '/src/Processors/ExpandEnums.php',