Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(example): add supported signing algorithms to RP #639

Closed
wants to merge 1 commit into from

Conversation

muhlemmer
Copy link
Collaborator

@muhlemmer muhlemmer commented Aug 19, 2024

This change adds supported signing algorithms the the app example's RP.

This algorithms will be added to zitadel in zitadel/zitadel#8449. This change makes the example work with any of the key types that can be configured in zitadel.

Related to zitadel/zitadel#8031

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@muhlemmer muhlemmer changed the base branch from feat-EdDSA-hasher to main August 19, 2024 18:09
@muhlemmer muhlemmer marked this pull request as ready for review August 20, 2024 09:28
@muhlemmer muhlemmer requested a review from livio-a August 20, 2024 09:28
@muhlemmer muhlemmer closed this Aug 20, 2024
@muhlemmer muhlemmer removed the request for review from livio-a August 20, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant