Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: approve and merge automatic PRs #239

Merged
merged 2 commits into from
Aug 27, 2024
Merged

chore: approve and merge automatic PRs #239

merged 2 commits into from
Aug 27, 2024

Conversation

eliobischof
Copy link
Member

@eliobischof eliobischof commented Aug 27, 2024 •
edited
Loading

This approves and enables auto-merge on PRs that are created automatically. This helps always having the chart up-to-date.

  • Test dependencies from dependabot PRs are updated without human interaction if tests pass.
  • App version updates (currently triggered manually) are updated without human interaction if tests pass. The PR fixes the current workflow definition that is supposed to auto-approve and auto-merge already (chore: helm chart bump.yml repair #236).

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

@eliobischof eliobischof self-assigned this Aug 27, 2024
@eliobischof eliobischof merged commit 2cd15dc into main Aug 27, 2024
10 checks passed
@eliobischof eliobischof deleted the automerge branch August 27, 2024 16:00
@eliobischof eliobischof mentioned this pull request Aug 27, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stebenz stebenz stebenz approved these changes

Assignees

@eliobischof eliobischof

Labels
None yet
Projects
Product Management
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliobischof @stebenz