feat: sourcing envVars from a secret #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hifabienne
added
the
os-contribution
eliobischof
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Hi @Smana
Thanks for yet another useful improvement. It can certainly be much more convenient to pass many env vars together using envVarsSecret.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to configure Zitadel using environment variables just like it is mentioned here.
This is particularly useful when using external secrets operator for instance, we could retrieve the database/user credentials from there without having to put them into the Helm variables.
This is an alternative to defining each environment variable specifically in the Helm values too.
My work in progress: Smana/cloud-native-ref#448