Add burnFrom burning function #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k1rill-fedoseev
force-pushed
the
feat/burn-from
branch
from
90e894c to
e56cff6
Compare
YusupovAI
approved these changes
Feb 7, 2023
k1rill-fedoseev
force-pushed
the
feat/burn-from
branch
from
e56cff6 to
1a3ee7f
Compare
AlexSaplin
approved these changes
Feb 10, 2023
akolotov
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some additional research within potential bridge integrations and other minting mechanics (see #27 #29), it became clear that
burnFromfunction will be a more convenient alternative, will generate cleaner history, and will be cheaper gas-wise.