Fix ff.metal and refactor rust test #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andom BigInt values - Changed the field tests to utilize random number generation for inputs, enhancing robustness against edge cases. - Updated the limb size and number of limbs from 20 to 16 for consistency. - Replaced the hardcoded values for the scalar field modulus with the BaseField's modulus. - Added assertions to ensure non-negativity and proper range for generated values. - Improved correctness checks by directly comparing results with expected values derived from Arkworks operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Improvements to arithmetic operations:
mopro-msm/src/msm/metal_msm/shader/field/ff.metal: Simplified theff_addfunction by usingbigint_add_unsafeandbigint_subinstead of their wide counterparts. This reduces the complexity of the addition and subtraction operations.Updates to tests:
mopro-msm/src/msm/metal_msm/tests/field/ff_add.rs: Updated thetest_ff_addfunction to userandfor generating random values and added checks to ensure values are non-negative and less than the modulus. Also, included validation of the result using Arkworks. [1] [2]mopro-msm/src/msm/metal_msm/tests/field/ff_sub.rs: Updated thetest_ff_subfunction to userandfor generating random values and added checks to ensure values are non-negative and less than the modulus. Also, included validation of the result using Arkworks.