Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/utils/limbs conversion #36

Merged
merged 3 commits into from
Jan 12, 2025
Merged

Feat/utils/limbs conversion #36

merged 3 commits into from
Jan 12, 2025

Conversation

moven0831
Copy link
Collaborator

This pull request makes several changes to the mopro-msm project, focusing on updating the usage of limb conversion utilities and modifying the BigInt type instantiation. The most important changes include replacing FromLimbs and ToLimbs with GenericLimbConversion and specifying the size parameter for BigInt.

Limb Conversion Utility Update:

BigInt Type Instantiation:

… GenericLimbConversion

- Updated multiple test files to use the new GenericLimbConversion trait for limb conversions.

- Modified multiple test files to use BigInt::<4>::rand and BigInt::<4>::from_limbs for consistent limb size specification.

- Removed deprecated FromLimbs and ToLimbs traits from limbs_conversion.rs, streamlining the conversion logic.
@moven0831 moven0831 self-assigned this Jan 12, 2025
@moven0831 moven0831 force-pushed the feat/utils/limbs_conversion branch from 4624276 to e1b9727 Compare January 12, 2025 11:29
Copy link
Collaborator

@FoodChain1028 FoodChain1028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mopro-msm/src/msm/metal_msm/utils/limbs_conversion.rs Outdated Show resolved Hide resolved
@moven0831 moven0831 merged commit 6fffa95 into main Jan 12, 2025
1 check passed
@moven0831 moven0831 deleted the feat/utils/limbs_conversion branch January 12, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants