Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed go package as zdns/dns instead of miekg/dns #8

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Renamed go package as zdns/dns instead of miekg/dns #8

merged 1 commit into from
Jun 10, 2024

Conversation

phillip-stephens
Copy link

This should let us use go get -u from zmap/zdns without running into:

$ go mod tidy
go: github.com/zmap/[email protected]: parsing go.mod:
        module declares its path as: github.com/miekg/dns
                but was required as: github.com/zmap/dns

@phillip-stephens phillip-stephens marked this pull request as ready for review June 10, 2024 01:31
@zakird zakird merged commit cc18066 into master Jun 10, 2024
6 checks passed
@zakird zakird deleted the phillip/fix-go-mod-module-name branch June 10, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakird zakird zakird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phillip-stephens @zakird