feat(hid): Add KConfig option for higher NKRO usages #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the maximum NKRO usage is set to maximise compatibility, but some keys dont work, this adds the ability to use those extended keys, at the cost of compatibiltity
caksoylar
reviewed
Nov 15, 2023
Co-authored-by: Cem Aksoylar <[email protected]>
petejohanson
requested changes
Nov 28, 2023
Co-authored-by: Pete Johanson <[email protected]>
petejohanson
requested changes
Nov 30, 2023
petejohanson
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the maximum NKRO usage is set to maximize compatibility, but some keys don't work. This adds the ability to use those extended keys, at the cost of compatibility (android doesn't like the higher usage range, it seems). The chosen max was largely arbitrary, although it needs to be a multiple of 8 - 1 (otherwise windows will refuse to enumerate it properly, reporting "driver error"), For this reason I made it a configurable bool rather than a variable value. There's also no reason to have it variable across a wide range, a low and a high value seem like a good compromise
This fix addresses #1460 and is linked to #1236