-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update language in experimental RPC API paramaters #1155
Conversation
Yes, “nb” is a usual French shorthand for “nombre”. So variable names such as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine and I agree with the change; I only have some extremely minor suggestions.
Co-authored-by: Marc van der Wal <[email protected]>
Co-authored-by: Marc van der Wal <[email protected]>
May I suggest |
Sure, I like it. I'll make an update. |
Purpose
This PR updates the terminology used in experimental RPC API methods.
Context
Fixes #1084.
Changes
In the RPC API the following input and output parameters are renamed.
How to test this PR
Make calls to each RPC method in the table above and make sure it accepts the new input parameters and that the new output parameters are present in the output.