Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix domain name command line argument handling #365

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

mattias-p
Copy link
Member

@mattias-p mattias-p commented Jan 8, 2024

Purpose

This PR fixes a couple of issues related to command line argument handling.

Context

This PR fixes items 1 and 2 in #364.

Changes

  • Domain names "" and "0" are not rejected as missing domain names.
  • The diagnostics/results separator is printed after input validation is completed.
  • As a drive-by change, the unused Test::Reflow dependency is also removed.

How to test this PR

Zonemaster CLI should present the following behaviors:

$ zonemaster-cli --show-testcase --no-ipv6 --test basic/basic01 
Must give the name of a domain to test.

$ zonemaster-cli --show-testcase --no-ipv6 --test basic/basic01 ''
Domain name is empty


$ zonemaster-cli --show-testcase --no-ipv6 --test basic/basic01 0                                                                                                                                      

Seconds Level    Testcase       Message
======= ======== ============== =======
...

@mattias-p mattias-p added this to the v2023.2 milestone Jan 9, 2024
@matsduf matsduf modified the milestones: v2023.2, v2024.1 Jan 10, 2024
@mattias-p mattias-p merged commit 53702ad into zonemaster:develop Apr 5, 2024
1 check passed
@mattias-p mattias-p added the V-Patch Versioning: The change gives an update of patch in version. label Jun 17, 2024
@marc-vanderwal
Copy link
Contributor

Testing was successful. Each of the command lines in the testing procedures yielded the expected output.

@marc-vanderwal marc-vanderwal added the S-ReleaseTested Status: The PR has been successfully tested in release testing label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-ReleaseTested Status: The PR has been successfully tested in release testing V-Patch Versioning: The change gives an update of patch in version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants