Fix alias (CNAME) handling in Address03 test case #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a proper unit test for the Address03 test case. Currently, it fails because of PTR-IS-GOOD-CNAME-2, because there is a bug in this scenario, but we’re going to fix it in a follow-up commit. A stale test, involving torsas.se which formerly had classless in-addr.arpa delegation, is disabled, because it isn’t classless in-addr.arpa anymore.
The recent refactoring of Zonemaster::Engine::Recursor makes the special handling of CNAME resource records entirely redundant, while introducing new bugs. In fact, these few lines caused aliases to be no longer properly followed if they point out of the zone, which often happens with classless in-addr.arpa delegations. Removing this special case is enough to fix the problem.
marc-vanderwal
added
A-TestCase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes a bug in the implementation of Address03, where the test case could fail to map an IP address to a domain name if a reverse query (PTR) for an IP address returns an alias (CNAME) in a different zone.
NOTE: This PR is in draft status because zonemaster/zonemaster#1354 is not merged yet.
Context
Fixes #1431.
Changes
How to test this PR
Unit tests have been added, and should pass.