Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update French version of the FAQ #360

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

marc-vanderwal
Copy link
Contributor

Purpose

This PR updates the French version of the FAQ.

Context

Fixes #354 and follows up to #347.

Changes

  • Update the French version of the FAQ to be in sync with the English version.
  • Fix a few more spelling/grammar issues I found when going over the document.

It seems that this translation went way out of sync with the English version in a few places. Therefore, more edits were necessary compared to #347.

How to test this PR

This is a documentation update.

@marc-vanderwal marc-vanderwal marked this pull request as ready for review November 9, 2022 13:26
@marc-vanderwal marc-vanderwal requested review from hannaeko, a user and tgreenx November 9, 2022 13:26
@marc-vanderwal marc-vanderwal added the A-Documentation Area: Documentation only. label Nov 9, 2022
@marc-vanderwal marc-vanderwal added this to the v2022.2 milestone Nov 9, 2022
@marc-vanderwal marc-vanderwal added A-Translation Documentation of, implementation of or actual translation of text and removed A-Documentation Area: Documentation only. labels Nov 9, 2022
@marc-vanderwal marc-vanderwal linked an issue Nov 9, 2022 that may be closed by this pull request
@matsduf matsduf added the V-Patch Versioning: The change gives an update of patch in version. label Nov 9, 2022
It seems that this translation has gone way out of sync with the English
version, hence the larger number of edits compared with the English FAQ
update appearing in pull request zonemaster#347.

A few of the paragraphs affected by the update have been entirely
rewritten and translations revised. The French translations for DNS
terms follow Stéphane Bortzmeyer's blog post [1] commenting RFC 8499.

[1]: https://www.bortzmeyer.org/8499.html
tgreenx
tgreenx previously approved these changes Nov 10, 2022
These edits are not strictly necessary for syncing the French FAQ with
the English version, but I found that the opportunity was right to go
over a few sentences that do not sound right.
@matsduf matsduf dismissed their stale review November 16, 2022 07:29

My requested change has been done. I cannot judge the rest.

@matsduf
Copy link
Contributor

matsduf commented Nov 25, 2022

I think this can be merged.

@marc-vanderwal marc-vanderwal merged commit 909f4e0 into zonemaster:develop Nov 28, 2022
@matsduf matsduf mentioned this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Translation Documentation of, implementation of or actual translation of text V-Patch Versioning: The change gives an update of patch in version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update French FAQ
3 participants