-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update French version of the FAQ #360
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8564d54
to
8ee3f74
Compare
Closed
tgreenx
reviewed
Nov 9, 2022
8ee3f74
to
7395c73
Compare
It seems that this translation has gone way out of sync with the English version, hence the larger number of edits compared with the English FAQ update appearing in pull request zonemaster#347. A few of the paragraphs affected by the update have been entirely rewritten and translations revised. The French translations for DNS terms follow Stéphane Bortzmeyer's blog post [1] commenting RFC 8499. [1]: https://www.bortzmeyer.org/8499.html
7395c73
to
4d34a93
Compare
tgreenx
previously approved these changes
Nov 10, 2022
matsduf
previously requested changes
Nov 10, 2022
These edits are not strictly necessary for syncing the French FAQ with the English version, but I found that the opportunity was right to go over a few sentences that do not sound right.
4d34a93
to
9b088f8
Compare
My requested change has been done. I cannot judge the rest.
tgreenx
approved these changes
Nov 16, 2022
I think this can be merged. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Translation
Documentation of, implementation of or actual translation of text
V-Patch
Versioning: The change gives an update of patch in version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR updates the French version of the FAQ.
Context
Fixes #354 and follows up to #347.
Changes
It seems that this translation went way out of sync with the English version in a few places. Therefore, more edits were necessary compared to #347.
How to test this PR
This is a documentation update.