-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate the assets directory #375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected, and also when using a custom base url.
Tested as part of 2022-2 release testing on Debian 11.
@blacksponge, I am not against it, but what risks do you see doing this very late in the release cycle? |
I did the smallest changes that I could to reduce the risk, and it has already been tested on two OSs. I do not forsee much risks coming from that but I still prefer to take it than deferring to next release and have something half finished for this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine to include it within this release.
@blacksponge, is issue #374 fully resolved by this PR? |
Yes it is |
Purpose
Since the migration to @angular/localize one bundle is generated per locale. This duplicates the assets.
While for the images it is sub-optimal but acceptable, for the configuration it is not. A user should not be required to update 6 times (or more in the future) the configuration, it is unpractical and error prone.
This PR changes the way the release zip is built to only use one assets folder. The asset folder is colocated with the locales folder to form the following architecture.
This way the assets folder is only present once. Also it means that our previous documentation still applies as the configuration path as not changed. Users will not have to move/copy the configuration file else where and will be able to reuse the existing one.
Context
#374
Changes
How to test this PR