Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation of strings to Spanish (GUI) #393 #396

Merged

Conversation

huguei
Copy link
Collaborator

@huguei huguei commented Feb 16, 2023

Purpose

Update of spanish translation messages.es.xlf file.

Context

Fixes #393

Changes

src/locale/messages.es.xlf

@matsduf
Copy link
Contributor

matsduf commented Feb 17, 2023

Thank you, @huguei!

In the table there are two "Undelegated" which you both translated to "No está delegado", which is fine if Spanish does not make a distinction between singular and plural context. English does not, but other languages like French and Swedish does. The first is for plural context and the second for singular context, which is noted in the notes for the translators which is shown in the lower right corner of the Poedit window (if you use that).

That was the only thing I saw, but I do not read Spanish.

@matsduf matsduf added this to the v2022.2.2 (fix) milestone Feb 17, 2023
@matsduf matsduf added the A-Translation Documentation of, implementation of or actual translation of text label Feb 17, 2023
@matsduf matsduf requested review from a user and matsduf February 17, 2023 09:25
@matsduf matsduf added A-Documentation Area: Documentation only. V-Patch Versioning: The change gives an update of patch in version. and removed A-Translation Documentation of, implementation of or actual translation of text labels Feb 17, 2023
@matsduf matsduf linked an issue Feb 17, 2023 that may be closed by this pull request
@huguei
Copy link
Collaborator Author

huguei commented Feb 17, 2023

Thank you, @huguei!

In the table there are two "Undelegated" which you both translated to "No está delegado", which is fine if Spanish does not make a distinction between singular and plural context. English does not, but other languages like French and Swedish does. The first is for plural context and the second for singular context, which is noted in the notes for the translators which is shown in the lower right corner of the Poedit window (if you use that).

That was the only thing I saw, but I do not read Spanish.

Sorry about that, I didn't notice the translator notes in poedit!
I've just reviewed again all the notes, and corrected this and other message. Also deleted an extra dot at the end of a message.
Thanks.

@matsduf
Copy link
Contributor

matsduf commented Feb 18, 2023

Sorry about that, I didn't notice the translator notes in poedit! I've just reviewed again all the notes, and corrected this and other message. Also deleted an extra dot at the end of a message. Thanks.

Thank you! I think it is easy to miss the translator notes.

@matsduf matsduf merged commit e3e3943 into zonemaster:release-branch-v2022.2.2 Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Documentation Area: Documentation only. V-Patch Versioning: The change gives an update of patch in version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update translation of strings to Spanish (GUI)
2 participants