Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor stats section for organization redesign - 4 #5577

Merged
merged 3 commits into from
Dec 6, 2019

Conversation

mcbouslog
Copy link
Contributor

@mcbouslog mcbouslog commented Dec 3, 2019

Staging branch URL: https://pr-5577.pfe-preview.zooniverse.org

Helpful links:

Describe your changes.

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you rm -rf node_modules/ && npm install and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on Travis?

Optional

@coveralls
Copy link

coveralls commented Dec 3, 2019

Coverage Status

Coverage increased (+0.003%) to 49.252% when pulling 40a08fd on org-stats-section into 1299c84 on org-redesign.

@mcbouslog mcbouslog force-pushed the org-stats-section branch 2 times, most recently from 0c86419 to f3cf817 Compare December 4, 2019 20:06
@mcbouslog
Copy link
Contributor Author

This has been rebased, ready for review.

@mcbouslog mcbouslog self-assigned this Dec 4, 2019
@mcbouslog mcbouslog changed the base branch from org-external-links to org-redesign December 6, 2019 18:34
@mcbouslog mcbouslog merged commit 647ad83 into org-redesign Dec 6, 2019
@mcbouslog mcbouslog deleted the org-stats-section branch December 16, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants