Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Donate Page Edits #5579

Merged
merged 2 commits into from
Dec 4, 2019
Merged

Final Donate Page Edits #5579

merged 2 commits into from
Dec 4, 2019

Conversation

wgranger
Copy link
Contributor

@wgranger wgranger commented Dec 4, 2019

Staging branch URL: https://pr-5579.pfe-preview.zooniverse.org

Fixes # .

Describe your changes.
Made some final changes to the copy on the "donation" tab

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you rm -rf node_modules/ && npm install and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on Travis?

Optional

@coveralls
Copy link

coveralls commented Dec 4, 2019

Coverage Status

Coverage remained the same at 49.178% when pulling b1a93ce on donate-page-edit into fd1be59 on master.

@mcbouslog mcbouslog merged commit abab2b0 into master Dec 4, 2019
@mcbouslog mcbouslog deleted the donate-page-edit branch December 4, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants