Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix font-size for organization landing content heading #5590

Closed
wants to merge 1 commit into from

Conversation

mcbouslog
Copy link
Contributor

@mcbouslog mcbouslog commented Dec 18, 2019

Staging branch URL: https://pr-5590.pfe-preview.zooniverse.org

Some of the last edits to the recent org landing redesign PR #5554 included adding or editing header elements for content and section headings. These edits changed the font-size for some headings, which previously were set on default or inherited sizing. This PR change explicitly sets the font-sizes in accordance with the design.

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you rm -rf node_modules/ && npm install and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on Travis?

Optional

@mcbouslog mcbouslog requested a review from wgranger December 18, 2019 17:16
@coveralls
Copy link

Coverage Status

Coverage remained the same at 49.352% when pulling f61b58d on org-landing-heading-style into 2d81e61 on master.

@mcbouslog
Copy link
Contributor Author

Closing in favor of new PR that addresses additional items as noted in #5592

@mcbouslog mcbouslog closed this Dec 19, 2019
@mcbouslog mcbouslog deleted the org-landing-heading-style branch December 20, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants