Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor media action with getAllLinked #5591

Closed
wants to merge 1 commit into from

Conversation

mcbouslog
Copy link
Contributor

@mcbouslog mcbouslog commented Dec 18, 2019

Staging branch URL: https://pr-5591.pfe-preview.zooniverse.org

Fixes lab/media page size issue, as noted in this Talk post.

Refactors media fetch action to use getAllLinked helper.

Comparing https://www.zooniverse.org/lab/5483/media to https://pr-5591.pfe-preview.zooniverse.org/lab/5483/media?env=production, searching for "https://panoptes-uploads", returns 200 results on master as expected compared to 427(!) on this staged branch.

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you rm -rf node_modules/ && npm install and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on Travis?

Optional

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 49.354% when pulling dcf00cf on media-fetch-page-size into 2d81e61 on master.

@wgranger
Copy link
Contributor

Nice. Good use of the lib function we already have. Are we at all concerned about providing limitless amounts of media uploads?

@mcbouslog
Copy link
Contributor Author

Closing in favor of paginator.

@mcbouslog mcbouslog closed this Dec 19, 2019
@mcbouslog mcbouslog deleted the media-fetch-page-size branch December 19, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants