Remove PlaceholderSVG xmlns, refactor maxHeight and maxWidth properties

zooniverse · Jan 29, 2025 · e6d5b39 · e6d5b39
1 parent cecd104
commit e6d5b39
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/...sifier/components/SubjectViewer/components/SingleImageViewer/components/PlaceholderSVG.js b/...sifier/components/SubjectViewer/components/SingleImageViewer/components/PlaceholderSVG.js
@@ -4,8 +4,8 @@ import styled, { css } from 'styled-components'
 const StyledPlaceholderSVG = styled.svg`
   background: no-repeat center / cover url('https://static.zooniverse.org/www.zooniverse.org/assets/fe-project-subject-placeholder-800x600.png');
   touch-action: pinch-zoom;
-  max-width: ${props => props.maxWidth};
-  ${props => props.maxHeight && css`max-height: ${props.maxHeight};`}
+  max-width: ${props => props.$maxWidth};
+  ${props => props.$maxHeight && css`max-height: ${props.$maxHeight};`}
 `
 
 function PlaceholderSVG({
@@ -17,11 +17,10 @@ function PlaceholderSVG({
     <StyledPlaceholderSVG
       data-testid='placeholder-svg'
       focusable
-      maxHeight={maxHeight}
-      maxWidth={maxWidth}
+      $maxHeight={maxHeight}
+      $maxWidth={maxWidth}
       tabIndex={0}
       viewBox={viewBox}
-      xmlns='http://www.w3.org/2000/svg'
     />
   )
 }