Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate (and remove) the TESS light curve viewer #5324

Open
1 of 6 tasks
eatyourgreens opened this issue Sep 12, 2023 · 0 comments
Open
1 of 6 tasks

Deprecate (and remove) the TESS light curve viewer #5324

eatyourgreens opened this issue Sep 12, 2023 · 0 comments
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request FEM spreadsheet Tracked in the FEM Planning spreadsheet (for zoo team members)

Comments

@eatyourgreens
Copy link
Contributor

eatyourgreens commented Sep 12, 2023

Package

Choose from the list:

  • app-content-pages
  • app-project
  • lib-classifier
  • lib-panoptes-js
  • lib-react-components
  • unknown

Is your feature request related to a problem? Please describe.

The LightCurveViewer is tied to d3 v6, which can't be upgraded to 7 (#3779.) Newer JSON subject viewers use VisX, which is based on d3 v7. PH-TESS subjects can be displayed by the ScatterPlotViewer component, so we currently have two viewers doing the same thing, depending on conflicting versions of d3.

Describe the solution you'd like

PH-TESS subjects can be displayed by the Scatter Plot Viewer. See the Kepler Light Curve story in the storybook.

Once the Scatter Plot Viewer supports task feedback (#5297), the LightCurveViewer component can be replaced and removed, along with d3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request FEM spreadsheet Tracked in the FEM Planning spreadsheet (for zoo team members)
Development

No branches or pull requests

2 participants