Generalise graph2dRange feedback to the scatter plot viewer

[eatyourgreens]

Graph2dRangeFeedback here is hardcoded to use the TESS LightCurveViewer. It should be generalised so that feedback can also be displayed in the scatter plot viewer eg. for Black Hole Hunters.

front-end-monorepo/packages/lib-classifier/src/components/Classifier/components/Feedback/components/Graph2dRangeFeedback.js

Lines 102 to 108 in c5fac08

	return (
	<LightCurveViewer
	data={data}
	drawFeedbackBrushes={drawFeedbackBrushes}
	feedback={feedback}
	/>
	)

[adammcmaster]

I think maybe this should have been closed when #5298 merged?

[eatyourgreens]

This should stay open until feedback is implemented in the scatter plot viewer. At the moment, it's only available in the light curve viewer, which is specific to PH-TESS subjects.

[adammcmaster]

Are you sure? I'm using feedback on BHH...

[eatyourgreens]

Yep. #5298 passes the feedback brushes down to the viewer, but theres no code in place to render them, which is why you aren't seeing any vertical bars for the simulated data.

[eatyourgreens]

feedbackBrushes are currently only available in the LCV, here:

front-end-monorepo/packages/lib-classifier/src/components/Classifier/components/SubjectViewer/components/LightCurveViewer/LightCurveViewer.js

Lines 41 to 44 in a10466b

	function drawFeedbackBrushes(d3annotationsLayer, repositionBrush, feedbackBrushes) {
	feedbackBrushes.forEach(feedbackBrush => {
	feedbackBrush.brush = brushX()
	})

[eatyourgreens]

I think that this can be closed once #5857 merges, and that would mean that the old light curve viewer can be deprecated (#5324.)

[eatyourgreens]

Closed by #5857.