Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph2dRangeFeedback Doesn't show correct answers #5856

Closed
1 of 6 tasks
adammcmaster opened this issue Jan 17, 2024 · 4 comments · Fixed by #5857
Closed
1 of 6 tasks

Graph2dRangeFeedback Doesn't show correct answers #5856

adammcmaster opened this issue Jan 17, 2024 · 4 comments · Fixed by #5857
Labels
bug Something isn't working

Comments

@adammcmaster
Copy link
Contributor

adammcmaster commented Jan 17, 2024

Package

Choose from the list:

  • app-content-pages
  • app-project
  • lib-classifier
  • lib-panoptes-js
  • lib-react-components
  • unknown

Describe the bug

I gather from #5298 that feedback used to show which annotations were incorrect and also used to show where the correct annotations should have been. Now it just seems to show the volunteer's annotations without indicating what the correct answer should have been.

To Reproduce

Steps to reproduce the behavior:

  1. Go to the BHH training workflow https://www.zooniverse.org/projects/cobalt-lensing/black-hole-hunters/classify/workflow/25860
  2. When classifying a subject with a lensing event, either don't mark it or mark the wrong part of the light curve.
  3. Submit the classification.
  4. The feedback window will open with the failure message, but the subject will be displayed without the correct ranges being highlighted.

Screenshots

IMG_0427

Expected behavior

The correct range (towards the left hand side in the above example) should be highlighted.

Device information

Desktop (please complete the following information):

  • OS: [e.g. Windows 10]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone]
  • OS:
  • Browser:
  • Versio:

Additional context

Add any other context about the problem here.

@adammcmaster adammcmaster added the bug Something isn't working label Jan 17, 2024
@eatyourgreens
Copy link
Contributor

Feedback hasn't been implemented yet for the scatter plot viewer. Once that's done, that should fix this.

@eatyourgreens
Copy link
Contributor

eatyourgreens commented Jan 17, 2024

@adammcmaster I've got feedback working on a branch. I can open a PR.

Green feedback for a successful detection in Black Hole Hunters. Red feedback for a missed detection in Black Hole Hunters.

@eatyourgreens
Copy link
Contributor

The subject viewer is still interactive in the popup. You can delete or edit annotations. I’ve also fixed that in #5857.

@eatyourgreens
Copy link
Contributor

AFAIK the popup opens after the classification is saved, so the editing bug shouldn’t affect classifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants