-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data selection feedback for scatter plots #5857
Data selection feedback for scatter plots #5857
Conversation
Screenshots here: #5856 (comment) |
b202285
to
7699c60
Compare
7699c60
to
721d5d6
Compare
94fe880
to
13666da
Compare
13666da
to
108df7e
Compare
Add `feedbackBrushes`, from PH-TESS, to the scatter plot viewer's `Selections` component. Show a green bar for each success, a red bar for each failure. Disable the subject viewer so that annotations can't be edited in the feedback popup. Add a selection feedback story, with mock feedback brushes.
108df7e
to
5fc957c
Compare
I've added a story and a couple of tests too. I had to bump the storybook to 7.6.9 to get it to build without erroring. See #5861. |
72c22fe
to
6b1e607
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Tested locally on https://local.zooniverse.org:3000/projects/cobalt-lensing/black-hole-hunters/classify/workflow/25860?demo=true without issue, feedback is as expected. The colors are a little confusing, but I know that's not related to these changes.
Testing on https://localhost:8080/?env=production&project=cobalt-lensing%2Fblack-hole-hunters&workflow=25860&demo=true resulted in two/duplicated Selections each time I made a Selection. I can not figure out why this is happening in lib-classifier, but not in app-project. 🤔 @eatyourgreens - do you see the same duplicated selections locally? Maybe it's me/my machine.
Add
feedbackBrushes
, from PH-TESS, to the scatter plot viewer'sSelections
component. Show a green bar for each success, a red bar for each failure.Disable the subject viewer so that annotations can't be edited in the feedback popup.
Add a selection feedback story, with mock feedback brushes.
Refactor
ScatterPlotViewer
so that it can be rendered withjsdom
.Please request review from
@zooniverse/frontend
team or an individual member of that team.Package
lib-classifier
Linked Issue and/or Talk Post
How to Review
Run Black Hole Hunters in the standalone classifier and try the training workflow. Every subject should have feedback.
https://localhost:8080/?env=production&project=cobalt-lensing%2Fblack-hole-hunters&workflow=25860
Checklist
PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.
General
yarn panic && yarn bootstrap
ordocker-compose up --build
and FEM works as expectedGeneral UX
Example Staging Project: i-fancy-cats
New Feature