Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump storybook to 7.6.9 #5861

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented Jan 18, 2024

Bump all @storybook packages to 7.6.9.

Please request review from @zooniverse/frontend team or an individual member of that team.

Package

  • app-content-pages
  • app-project
  • lib-classifier
  • lib-react-components

Linked Issue and/or Talk Post

How to Review

Development and production storybook builds should run without error.

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected

Bug Fix

  • The PR creator has listed user actions to use when testing if bug is fixed
  • The bug is fixed
  • Unit tests are added or updated

Maintenance

  • If not from dependabot, the PR creator has described the update (major, minor, or patch version, changelog)

Sorry, something went wrong.

Bump all `@storybook` packages to 7.6.9.
@eatyourgreens
Copy link
Contributor Author

This fixed the storybook for me, so that I was able to run the classifier storybook and check the new story in #5857.

@coveralls
Copy link

coveralls commented Jan 18, 2024

Coverage Status

coverage: 81.244% (+0.01%) from 81.234%
when pulling 0208aa6 on eatyourgreens:bump-storybook
into 1d3f19c on zooniverse:master.

Copy link
Contributor

@mcbouslog mcbouslog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed storybooks work locally 👍

@mcbouslog mcbouslog merged commit 9cbdfa1 into zooniverse:master Jan 19, 2024
8 checks passed
@eatyourgreens eatyourgreens deleted the bump-storybook branch January 20, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev storybook errors on startup with 'mainConfigMatches is not iterable'
3 participants