Setup for multi frame subjects #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Subject#getViewer() assigns the multiFrame subject viewer to subjects with between 2 and 10 frames. - The SubjectFactory defaults to creating a subject with 11 frames to test for a default viewer of null when none of the viewer conditions are met.
…image_mode'] is 'separate'
…_switching_flipbook_and_separate'] is true
…configuration.subject_viewer is 'multiFrame'
simensta
changed the title
mcbouslog
approved these changes
Dec 5, 2019
| expect(subjectStore.viewer).to.be.null() | ||
| }) | ||
|
|
||
| it('should return the multiFrame viewer if the workflow configuration for subject_viewer is defined as multiFrame', function () { |
There was a problem hiding this comment.
This is to test that regardless of the subject, including type or number of locations, if the workflow config is set to use multi frame viewer then the subject uses the multi frame viewer? Nice!
There was a problem hiding this comment.
It is, however, I am realizing there is an assumption that { subject_viewer: 'multiFrame' } can only be enabled for subjects with between 2 and 10 frames.
There was a problem hiding this comment.
I will need to revisit this logic when creating a workflow config option in the lab editor. Thank you for the question!
There was a problem hiding this comment.
@beckyrother is working on some preliminary ideas for the workflow lab editor page with these new configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please request review from
@zooniverse/frontendteam. If PR is related to design, please request review from@beckyrotherin addition.Package: lib-classifier
Closes #1344
Describe your changes:
This PR sets up the folders, files, and logic for rendering the multiFrame subject viewer. For this PR, the MultiFrameViewer component itself is a simple placeholder.
The multiFrame viewer will render if:
{ subject_viewer: 'multiFrame' }or the subject has between 2 and 10 framesReview Checklist
General
Components
Apps
yarn panic && yarn bootstrapordocker-compose up --buildand app works as expected?Publishing
Post-merging