Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to webpack v5 #265

Closed
wants to merge 5 commits into from
Closed

Upgrade to webpack v5 #265

wants to merge 5 commits into from

Conversation

mcbouslog
Copy link
Contributor

@mcbouslog mcbouslog commented Feb 14, 2022 •
edited
Loading

Staging branch URL: https://pr-265.lab-preview.zooniverse.org/

Describe your changes.

  • upgrades to webpack v5 and related packages
  • remove node-sass, add sass

Draft:

  • can't sign-in, landing page looks as expected

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Can you rm -rf node_modules/ && npm install and app works as expected?
  • Are the tests passing locally and on Travis?

@mcbouslog mcbouslog closed this Feb 16, 2022
@mcbouslog
Copy link
Contributor Author

I think failed because of the issue described here - zooniverse/panoptes-javascript-client#153 - which also includes steps to resolve the issue.

@mcbouslog mcbouslog deleted the upgrade-webpack-v5 branch September 30, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mcbouslog