Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow .reload() on POST requests #76

Closed
wants to merge 1 commit into from
Closed

Disallow .reload() on POST requests #76

wants to merge 1 commit into from

Conversation

mgedmin
Copy link
Member

@mgedmin mgedmin commented Jun 27, 2019 •
edited by icemac
Loading

Fixes #74.

TODO:

  • fix test
  • changelog entry

@mgedmin
Copy link
Member Author

mgedmin commented Jun 28, 2019

Ok, there's an existing test that wants .reload() to repeat the form submission. So: I shouldn't forbid it, but instead I should reproduce the error I've seen and see if I can fix things.

@mgedmin mgedmin closed this Jul 1, 2019
@mgedmin mgedmin deleted the no-reload-of-post branch July 1, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.reload() fails if the previous request was a POST
1 participant
@mgedmin