Cleaning up NockApp::work/run, std::path and canonicalization for the paths in Choo #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamsden
approved these changes
Jan 8, 2025
bitemyapp
force-pushed
the
bitemyapp/use-std-path
branch
2 times, most recently
from
6cdc585 to
08e5d24
Compare
eamsden
approved these changes
Jan 15, 2025
bitemyapp
changed the title
bitemyapp
force-pushed
the
bitemyapp/use-std-path
branch
2 times, most recently
from
3e8a651 to
614d8ae
Compare
bitemyapp
changed the title
Purge inappropriate uses of std::process::exit, make task execution cooperative Cleaning up NockApp work_loop
bitemyapp
force-pushed
the
bitemyapp/use-std-path
branch
from
614d8ae to
9e80d6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.