Well-mannered panic handling #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitemyapp
force-pushed
the
bitemyapp/well-mannered-panic-handling
branch
from
9aba434 to
ad84945
Compare
|
I think this had already made it in in an earlier PR so I'm going to drop it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends upon zorp-corp/sword#285
Choo harness now catches, discriminates, and reports panics. I can repro a stack error at size = 1 and an OOM error at size = 1000. I also cleaned up choo's main a bit.
This required using
std::panic::AssertUnwindSafeandfutures::FutureExtfor.catch_unwind().Crown doesn't let the users set the NockStack size, so I had to override it to the
1and1_000case to repro the panics.