Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interpreter: flop traces #290

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcusmiguel
Copy link

Traces are inverted, and sometimes they force you to scroll up unnecessarily to figure out what went wrong.

before

2024-12-31T16:31:26.832404Z TRACE slogger: ------^
2024-12-31T16:31:26.832446Z TRACE slogger: ++  p arse-pile
2024-12-31T16:31:26.832450Z TRACE slogger: syntax error at [128 7] in /apps/choo/bootstrap/kernel.hoon   
2024-12-31T16:31:26.832455Z TRACE slogger: /apps/choo/bootstrap/kernel.hoon:<[136 3].[148 5]>
2024-12-31T16:31:26.832458Z TRACE slogger: /apps/choo/bootstrap/kernel.hoon:<[134 3].[148 5]>
2024-12-31T16:31:26.832461Z TRACE slogger: /apps/choo/bootstrap/kernel.hoon:<[131 3].[148 5]>
2024-12-31T16:31:26.832463Z TRACE slogger: /apps/choo/bootstrap/kernel.hoon:<[130 3].[148 5]>
2024-12-31T16:31:26.832466Z TRACE slogger: /apps/choo/bootstrap/kernel.hoon:<[360 27].[360 59]>
<...more here>
2024-12-31T16:31:26.832532Z TRACE slogger: /lib/wrapper.hoon:<[80 7].[88 54]>
2024-12-31T16:31:26.832534Z TRACE slogger: /lib/wrapper.hoon:<[79 7].[88 54]>
2024-12-31T16:31:26.832536Z TRACE slogger: /lib/wrapper.hoon:<[71 5].[89 7]>
2024-12-31T16:31:26.832538Z TRACE slogger: /lib/wrapper.hoon:<[70 5].[89 7]>

after

2024-12-31T16:27:52.929744Z TRACE slogger: /lib/wrapper.hoon:<[70 5].[89 7]>
2024-12-31T16:27:52.929785Z TRACE slogger: /lib/wrapper.hoon:<[71 5].[89 7]>
2024-12-31T16:27:52.929789Z TRACE slogger: /lib/wrapper.hoon:<[79 7].[88 54]>
2024-12-31T16:27:52.929792Z TRACE slogger: /lib/wrapper.hoon:<[80 7].[88 54]>
2024-12-31T16:27:52.929795Z TRACE slogger: /lib/wrapper.hoon:<[81 7].[88 54]>
<...more here>
2024-12-31T16:27:52.929858Z TRACE slogger: /apps/choo/bootstrap/kernel.hoon:<[360 3].[389 36]>
2024-12-31T16:27:52.929860Z TRACE slogger: /apps/choo/bootstrap/kernel.hoon:<[360 13].[360 64]>
2024-12-31T16:27:52.929862Z TRACE slogger: /apps/choo/bootstrap/kernel.hoon:<[360 27].[360 59]>
2024-12-31T16:27:52.929864Z TRACE slogger: /apps/choo/bootstrap/kernel.hoon:<[130 3].[148 5]>
2024-12-31T16:27:52.929867Z TRACE slogger: /apps/choo/bootstrap/kernel.hoon:<[131 3].[148 5]>
2024-12-31T16:27:52.929869Z TRACE slogger: /apps/choo/bootstrap/kernel.hoon:<[134 3].[148 5]>
2024-12-31T16:27:52.929871Z TRACE slogger: /apps/choo/bootstrap/kernel.hoon:<[136 3].[148 5]>
2024-12-31T16:27:52.929873Z TRACE slogger: syntax error at [128 7] in /apps/choo/bootstrap/kernel.hoon   
2024-12-31T16:27:52.929875Z TRACE slogger: ++  p arse-pile
2024-12-31T16:27:52.929876Z TRACE slogger: ------^

@marcusmiguel marcusmiguel marked this pull request as draft January 1, 2025 14:40
@marcusmiguel
Copy link
Author

marcusmiguel commented Jan 1, 2025

There is actually a flop argument in mook (currently broken but fixed by #291) that allows traces to be inverted.. However, inverting it inside mook won't work well in all cases because some traces are actually multiple lists that were previously +zinged together, each of which should be inverted individually. Therefore, either the traces should be flopped here, or the caller of the interpreter will need to manually +flop each one before invoking +mook. the traces need to be inverted before being welded in exit.

@marcusmiguel marcusmiguel marked this pull request as ready for review January 1, 2025 18:42
@eamsden eamsden changed the base branch from status to master January 10, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant