-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MODELTRANS_DEFAULT_LANGUAGE setting #117
Add MODELTRANS_DEFAULT_LANGUAGE setting #117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use case seems to be fair, and the implementation doesn't add much complexity 👍
I think we should add this setting to the documentation. Can you extend the PR with documentation for this setting?
da2b52d
to
4ecb809
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nitpick, and a test failure (slightly annoying false positive in the spell check, "middlewares" need to be added to https://github.com/zostera/django-modeltrans/blob/master/docs/spelling_wordlist.txt)
I'll merge and create a new release after these are resolved...
Co-authored-by: Jan Pieter Waagmeester <[email protected]>
b32e8bd
to
4cfa7a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
See use case in #116.
I worked with the existing test suite using the following patch and verified that everything still passed as expected:
I also added
DefaultLanguageConfTest
to verify that settings override got picked up.Please let me know if there are any additional tests / documentation that would be required.