Fix bug seriesTitle and series #1348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seriesTitle and series do not show after export item and then import that.
adam3smith
reviewed
Jul 5, 2017
| @@ -244,7 +244,7 @@ function generateItem(item, zoteroType, resource) { | |||
| // set series type | |||
| Zotero.RDF.addStatement(series, rdf+"type", n.bib+"Series", false); | |||
| // add relationship to resource | |||
| Zotero.RDF.addStatement((containerElement ? containerElement : resource), n.dcterms+"isPartOf", series, false); | |||
| Zotero.RDF.addStatement(resource, n.dcterms+"isPartOf", series, false); | |||
There was a problem hiding this comment.
Thanks but I don't think this is the right fix -- if there is a container (i.e. a book or a journal) the series term should be applied to that with the isPartOf term, not to the article/chapter. This needs to get fixed on import, not on export.
There was a problem hiding this comment.
ticket created to track this: #1350
|
I'm going to close this here, since import is in a different translator, but it'd be great if you'd take that one, obviously (I believe that should be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seriesTitle and series do not show after export item and then import that.