chore: Add debug message for passticket generation during authentication transformation to detect real issue with configuration (v2) #3969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Jareš <[email protected]>
github-actions
bot
added
the
Sensitive
pablocarle
reviewed
Jan 30, 2025
| @@ -106,6 +107,7 @@ public AuthenticationCommand createCommand(Authentication authentication, AuthSo | |||
| } catch (IRRPassTicketGenerationException e) { | |||
| String error = String.format("Could not generate PassTicket for user ID %s and APPLID %s", userId, applId); | |||
| logger.log(MessageType.DEBUG, error); | |||
There was a problem hiding this comment.
is this other one not appearing in the spool?
Maybe let's keep only yours, this is redundant I think
There was a problem hiding this comment.
It is definetelly not redundant, the current log doesn't contains response codes. There is just message about failure without details.
There was a problem hiding this comment.
right, so why keep the one without details?
There was a problem hiding this comment.
Oh, I see. That makes sense. Thanks, updated.
|
Signed-off-by: Pavel Jareš <[email protected]>
pablocarle
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a log message, which could improve the analysis of configuration issues in the APIML.
Linked to # (issue)
Part of the # (epic)
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline