-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace default spring x509 authentication in zaas #3971
Open
richard-salac
wants to merge
10
commits into
v3.x.x
Choose a base branch
from
reboot/fix/replace-default-x509-auth
base: v3.x.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Sensitive
Sensitive change that requires peer review
label
Jan 30, 2025
Signed-off-by: Richard Salac <[email protected]>
richard-salac
force-pushed
the
reboot/fix/replace-default-x509-auth
branch
from
January 30, 2025 10:43
26ecb0e
to
8fa0f70
Compare
Signed-off-by: Richard Salac <[email protected]> Signed-off-by: Richard Salac <[email protected]>
Signed-off-by: Richard Salac <[email protected]> Signed-off-by: Richard Salac <[email protected]>
Signed-off-by: Richard Salač <[email protected]>
richard-salac
force-pushed
the
reboot/fix/replace-default-x509-auth
branch
2 times, most recently
from
January 31, 2025 22:35
62e857f
to
9d17404
Compare
Signed-off-by: Richard Salac <[email protected]>
richard-salac
force-pushed
the
reboot/fix/replace-default-x509-auth
branch
from
January 31, 2025 23:00
9d17404
to
c75cd98
Compare
Signed-off-by: Richard Salac <[email protected]>
Signed-off-by: Richard Salac <[email protected]>
Signed-off-by: Richard Salac <[email protected]>
Signed-off-by: Richard Salac <[email protected]>
Signed-off-by: Richard Salac <[email protected]>
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Zaas is using two level authentication, Zowe server certificate is required on top of traditional client authentication (x509, credentials, token,....). This is causing unexpected behavior with spring X509 authentication when Zowe server certificate may get propagated as authenticated username. To avoid such situations the spring x509 was disabled when possible.
Linked to # (issue)
Part of the # (epic)
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline