review docs for accuracy and update #210
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
=======================================
Coverage 28.25% 28.25%
=======================================
Files 146 146
Lines 4987 4987
Branches 869 869
=======================================
Hits 1409 1409
Misses 3578 3578 ☔ View full report in Codecov by Sentry. |
davenice
force-pushed
the
niced-update-docs
branch
2 times, most recently
from
46358e9 to
f05b858
Compare
Signed-off-by: Dave Nice <[email protected]>
davenice
force-pushed
the
niced-update-docs
branch
from
f05b858 to
bacde10
Compare
Co-authored-by: Andrew <[email protected]> Signed-off-by: Dave Nice <[email protected]>
Signed-off-by: Dave Nice <[email protected]>
|
@zFernand0 - would there be a good person on your side to review this? |
Signed-off-by: anaxceron <[email protected]>
packages/vsce/README.md
Outdated
|
|
||
| **Tip:** The default 500 count can be modified via the `Record Count Increment` property in Settings (UI). | ||
| **Tip:** The default 500 count can be modified via the `Record Count Increment` property in Settings (UI). **[What does "(UI)" mean here? I don't see it in the screenshot.]** |
There was a problem hiding this comment.
UI means the settings page in VS Code rather than the config file, I imagine. Please check my clarified wording @anaxceron
There was a problem hiding this comment.
(In fact I found another place where we talk about the settings and have now taken the wording from there!)
packages/vsce/README.md
Outdated
|
|
||
| <p align="center"> | ||
| <img src="/packages/vsce/docs/images/disable-enable.gif" alt="Zowe CICS Explorer Filter" width="700px"/> | ||
| </p> | ||
|
|
||
| ### New Copy and Phase In | ||
|
|
||
| Use `New Copy` <img src="/packages/vsce/docs/images/program-newcopy-action.png" width="16px"/> and `Phase In` <img src="/packages/vsce/docs/images/program-phasein-action.png" width="16px"/> actions against a CICS program to get the CICS region to load a fresh of the selected program into memory. This could be after you've edited a COBOL program source and successfully compiled it into a load library and now want to test your change. | ||
| Use `New Copy` <img src="/packages/vsce/docs/images/program-newcopy-action.png" width="16px"/> and `Phase In` <img src="/packages/vsce/docs/images/program-phasein-action.png" width="16px"/> actions against a CICS program to get the CICS region to load a fresh of **[is there a word missing here? "a fresh of" what?]** the selected program into memory. This could be after you have edited a COBOL program source and successfully compiled it into a load library so that you can test your change. |
There was a problem hiding this comment.
Thanks - I've updated the wording to be inspired by the CICS doc - https://www.ibm.com/docs/en/cics-ts/5.6?topic=sc-set-program
I hadn't spotted this flagrant typo! Good catch :-)
Signed-off-by: Dave Nice <[email protected]>
|
@anaxceron - I think I've addressed everything you mentioned and this PR is good to go again from my perspective, assuming you agree with what I've done! |
Signed-off-by: Dave Nice <[email protected]>
What It Does
Resolves #209
How to Test
The easiest place to review the changes look good is https://github.com/zowe/cics-for-zowe-client/blob/niced-update-docs/packages/vsce/README.md
Review Checklist
I certify that I have:
Additional Comments