Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 3.0.3 release #3317

Open
wants to merge 15 commits into
base: release/3.0
Choose a base branch
from
Open

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Nov 14, 2024

Proposed changes

updates lerna and changelogs for patch release

Release Notes

Milestone: 3.0.3

Changelog: n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

benjamin-t-santos and others added 12 commits November 7, 2024 13:45
…asets and members (#3255)

* Fix PDS members in fetchDataset

Signed-off-by: Benjamin Santos <[email protected]>

* Update DatasetFSProvider.unit.test.ts

Signed-off-by: Benjamin Santos <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Benjamin Santos <[email protected]>

* Merge branch 'main' into datasetfsprovider-remote-lookup-fix

Signed-off-by: Benjamin Santos <[email protected]>

* move changelog update

Signed-off-by: Benjamin Santos <[email protected]>

* improve logic

Signed-off-by: Benjamin Santos <[email protected]>

* add ? after checking dsorg

Signed-off-by: Benjamin Santos <[email protected]>

* do not fetch attributes for members

Signed-off-by: Benjamin Santos <[email protected]>

---------

Signed-off-by: Benjamin Santos <[email protected]>
* fix: use vscode.workspace.fs to rename URIs

Signed-off-by: Trae Yelovich <[email protected]>

* chore: update ZE changelog

Signed-off-by: Trae Yelovich <[email protected]>

* update mocks, remaining use of delete/rename

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>
…ds (#3275)

* To handle missing args in basicAuthClearSecureArray

Signed-off-by: Santhoshi Boyina <[email protected]>

* To handle missing args in tokenAuthClearSecureArray

Signed-off-by: Santhoshi Boyina <[email protected]>

* To add unit test case for missing arg's in basicAuthClearSecureArray

Signed-off-by: Santhoshi Boyina <[email protected]>

* To add unit test case for missing arg's in tokenAuthClearSecureArray

Signed-off-by: Santhoshi Boyina <[email protected]>

* To run pre-publish command

Signed-off-by: Santhoshi Boyina <[email protected]>

* To update changelog

Signed-off-by: Santhoshi Boyina <[email protected]>

* To modify tokenAuthClearSecureArray() function

Signed-off-by: Santhoshi Boyina <[email protected]>

* To add additional test cases for tokenAuthClearSecureArray()

Signed-off-by: Santhoshi Boyina <[email protected]>

---------

Signed-off-by: Santhoshi Boyina <[email protected]>
…lization (#3274)

* fix: check if profileInfo is nullish during v1 migration

Signed-off-by: Trae Yelovich <[email protected]>

* chore: update ZE changelog

Signed-off-by: Trae Yelovich <[email protected]>

* tests: integration test for broken config

Signed-off-by: Trae Yelovich <[email protected]>

* add unit test for nullish profileinfo

Signed-off-by: Trae Yelovich <[email protected]>

* fix transient failures in UpdateCredentials scenario

Signed-off-by: Trae Yelovich <[email protected]>

* remove extra join import in wdio conf

Signed-off-by: Trae Yelovich <[email protected]>

* make integration test more reliable

Signed-off-by: Trae Yelovich <[email protected]>

* move getprofileinfo call into try/catch during profiles init

Signed-off-by: Trae Yelovich <[email protected]>

* test: open notification center to check for dialog

Signed-off-by: Trae Yelovich <[email protected]>

* add license header to test; add another null check

Signed-off-by: Trae Yelovich <[email protected]>

* add typedoc to ProfilesUtils.getProfileInfo

Signed-off-by: Trae Yelovich <[email protected]>

* setupDefaultCredentialManager: log err msgs, update typedoc

Signed-off-by: Trae Yelovich <[email protected]>

* test: promptUserWithNoConfigs, nullish profileInfo case

Signed-off-by: Trae Yelovich <[email protected]>

* refactor typedoc for setupDefaultCredentialManager

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>
#3268)

Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Co-authored-by: Billie Simmons <[email protected]>
* fix: show 'No config detected' prompt once when ZE opened

Signed-off-by: Trae Yelovich <[email protected]>

* chore: update ZE changelog

Signed-off-by: Trae Yelovich <[email protected]>

* resolve failing tests

Signed-off-by: Trae Yelovich <[email protected]>

* refactor: move event into static fn, add coverage

Signed-off-by: Trae Yelovich <[email protected]>

* update changelog

Signed-off-by: Trae Yelovich <[email protected]>

* patch coverage for ProfilesUtils.promptUserWithNoConfigs

Signed-off-by: Trae Yelovich <[email protected]>

* move variable definition

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Co-authored-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
* fix: pass responseTimeout to API functions

Signed-off-by: Trae Yelovich <[email protected]>

* refactor: remove fallback for spreading newOptions

Signed-off-by: Trae Yelovich <[email protected]>

* refactor: use optional chaining; work on resolving tests

Signed-off-by: Trae Yelovich <[email protected]>

* refactor: pass profile props to tests, fix types

Signed-off-by: Trae Yelovich <[email protected]>

* tests: resolve failing cases in ZE

Signed-off-by: Trae Yelovich <[email protected]>

* chore: update changelog entry for ZE API

Signed-off-by: Trae Yelovich <[email protected]>

* refactor: remove fallback for spreading undefined options

Signed-off-by: Trae Yelovich <[email protected]>

* fix: add missing functions to MvsApi test list

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>

Third-Party DCO Remediation Commit for benjamin-t-santos <[email protected]>

On behalf of benjamin-t-santos <[email protected]>, I, Fernando Rijo Cedeno <[email protected]>, hereby add my Signed-off-by to this commit: 8957a64

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

Third-Party DCO Remediation Commit for SanthoshiBoyina1 <[email protected]>

On behalf of SanthoshiBoyina1 <[email protected]>, I, Fernando Rijo Cedeno <[email protected]>, hereby add my Signed-off-by to this commit: 86a82f6

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

Signed-off-by: Fernando Rijo Cedeno <[email protected]>
* fix(ds): Call remoteLookupForResource when entry doesn't exist locally

Signed-off-by: Trae Yelovich <[email protected]>

* readFile() uses one MVS API call

Signed-off-by: Benjamin Santos <[email protected]>

* update unit tests, fix logic of calls

Signed-off-by: Benjamin Santos <[email protected]>

* fix lint error

Signed-off-by: Benjamin Santos <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Benjamin Santos <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Benjamin Santos <[email protected]>
Signed-off-by: benjamin-t-santos <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
* updates to webpack and package.json for dev mode

Signed-off-by: Billie Simmons <[email protected]>

* Remove endless startup loop when default CM cannot be loaded

Signed-off-by: Peter Haumer <[email protected]>

* Initial set of test updates

Signed-off-by: Peter Haumer <[email protected]>

* Merge branch 'main' into change-credentials-manager-check

Signed-off-by: Peter Haumer <[email protected]>

* Convenience launch to only run currently open test

Signed-off-by: Peter Haumer <[email protected]>

* Fixed ProfileUtils tests

Signed-off-by: Peter Haumer <[email protected]>

* Clean up package files

Signed-off-by: Peter Haumer <[email protected]>

* Updated changelog

Signed-off-by: Peter Haumer <[email protected]>

* Reworded info message

Signed-off-by: Peter Haumer <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* Added detail to info message

Signed-off-by: Peter Haumer <[email protected]>

* Updated resource files

Signed-off-by: Peter Haumer <[email protected]>

---------

Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Peter Haumer <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Co-authored-by: Billie Simmons <[email protected]>
Co-authored-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
@JillieBeanSim JillieBeanSim added the no-changelog Add to PR's that don't require a CHANGELOG update label Nov 14, 2024
@JillieBeanSim JillieBeanSim added this to the v3.0.3 milestone Nov 14, 2024
@JillieBeanSim JillieBeanSim self-assigned this Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.05%. Comparing base (e1c39ad) to head (246ca93).

Additional details and impacted files
@@             Coverage Diff              @@
##           release/3.0    #3317   +/-   ##
============================================
  Coverage        93.05%   93.05%           
============================================
  Files              113      113           
  Lines            11815    11815           
  Branches          2672     2681    +9     
============================================
  Hits             10994    10994           
  Misses             819      819           
  Partials             2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zFernand0
zFernand0 previously approved these changes Nov 14, 2024
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

To make changelog reviews easier...

Zowe Explorer API

  • Fixed an issue where the responseTimeout profile property was ignored for z/OSMF MVS and USS API calls. #3225

Zowe Explorer VSCE

  • DatasetFSProvider.stat() will now throw a FileNotFound error for extenders trying to fetch an MVS resource that does not exist. #3252
  • Fixed an issue where renaming or deleting a USS file or data set did not update the opened editor. #3260
  • Fixed an issue during initialization where a broken team configuration file caused the "Show Config" action in the error dialog to stop working. #3273
  • Fixed issue where switching the authentication methods would cause Cannot read properties of undefined error. #3142
  • Fixed an issue where calling vscode.workspace.fs.readFile with a PDS member URI would throw an error when the PDS already existed as a filesystem entry. #3267
  • Fixed issue where Zowe Explorer would present the "No configs detected" notification when initialized in a workspace without a Zowe team configuration. #3280
  • Reduced the number of MVS API calls performed by vscode.workspace.fs.readFile when fetching the contents of a data set entry. #3278
  • Fixed an issue to review inconsistent capitalization across translation strings. #2935
  • Updated the test for the default credential manager for better compatibility with Cloud-based platforms such as Eclipse Che and Red Hat OpenShift Dev Spaces. #3297

@anaxceron
Copy link
Contributor

anaxceron commented Nov 14, 2024

LGTM! 😋

To make changelog reviews easier...

Zowe Explorer API

  • Fixed an issue where the responseTimeout profile property was ignored for z/OSMF MVS and USS API calls. #3225

Zowe Explorer VSCE

  • DatasetFSProvider.stat() will now throw a FileNotFound error for extenders trying to fetch an MVS resource that does not exist. #3252
  • Fixed an issue where renaming or deleting a USS file or data set did not update the opened editor. #3260
  • Fixed an issue during initialization where a broken team configuration file caused the "Show Config" action in the error dialog to stop working. #3273
  • Fixed issue where switching the authentication methods would cause Cannot read properties of undefined error. #3142
  • Fixed an issue where calling vscode.workspace.fs.readFile with a PDS member URI would throw an error when the PDS already existed as a filesystem entry. #3267
  • Fixed issue where Zowe Explorer would present the "No configs detected" notification when initialized in a workspace without a Zowe team configuration. #3280
  • Reduced the number of MVS API calls performed by vscode.workspace.fs.readFile when fetching the contents of a data set entry. #3278
  • Fixed an issue to review inconsistent capitalization across translation strings. #2935
  • Updated the test for the default credential manager for better compatibility with Cloud-based platforms such as Eclipse Che and Red Hat OpenShift Dev Spaces. #3297

@JillieBeanSim -- I'd like to make the following edits to these changelog entries:

  • We should explain what DatasetFSProvider.stat() is: The DatasetFSProvider.stat() property/profile/whatever now throws a FileNotFound error for extenders trying to fetch an MVS resource that does not exist.

  • We should add an indefinite articles here, and remove "the": Fixed an issue where switching authentication methods would cause a Cannot read properties of undefined error.

  • We should add an indefinite articles here: Fixed an issue where Zowe Explorer would present the "No configs detected" notification when initialized in a workspace without a Zowe team configuration.

  • We should define what vscode.workspace.fs.readFileis: Reduced the number of MVS API calls performed by the property/value/what vscode.workspace.fs.readFile when fetching the contents of a data set entry.

  • For more clarity: Fixed inconsistent capitalization across translation strings.

  • For more clarity: Updated the check for default credential managers for better compatibility with Cloud-based platforms such as Eclipse Che and Red Hat OpenShift Dev Spaces.

Base automatically changed from port-fixes-4303 to release/3.0 November 16, 2024 17:13
@zFernand0 zFernand0 dismissed their stale review November 16, 2024 17:13

The base branch was changed.

…scode into prepare-3.0.3-release

Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
@zFernand0 zFernand0 self-requested a review November 18, 2024 14:56
@zFernand0 zFernand0 marked this pull request as ready for review November 18, 2024 14:56
Copy link

📅 Suggested merge-by date: 12/2/2024

Signed-off-by: Fernando Rijo Cedeno <[email protected]>
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 18, 2024
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I'm allowed to approve, but LGTM! 😋

Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @JillieBeanSim and @zFernand0!

@JillieBeanSim
Copy link
Contributor Author

JillieBeanSim commented Nov 18, 2024

thanks @anaxceron & @zFernand0.

@t1m0thyj @traeok @adam-wolfe @likhithanimma1 @awharn @SanthoshiBoyina1 anyone find any issues testing?

@zFernand0
Copy link
Member

Since the last commit only changed the lock file, the build wasn't triggered.
For a complete passing build, see the checks in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update size/M
Projects
Status: Review/QA
Development

Successfully merging this pull request may close these issues.

7 participants