Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload test results in CI when there are failing tests #3322

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Nov 15, 2024

Proposed changes

This is useful for debugging integration tests since we can download screenshots of failing tests 😋

Also fixes failing npm audit, and hopefully fixes transient errors in integration tests:

  • ShowConfigErrorDialog - since sometimes notifications are hidden in the notification center and other times they are still visible, it seems like we need to check both places
  • UpdateCredentials - it seems more reliable to add profile via quick pick instead of expecting ZE to auto-detect a new default profile

Release Notes

Milestone: N/A

Changelog: N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.99%. Comparing base (7143336) to head (32fa6e0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3322   +/-   ##
=======================================
  Coverage   92.99%   92.99%           
=======================================
  Files         116      116           
  Lines       12069    12069           
  Branches     2738     2737    -1     
=======================================
  Hits        11224    11224           
  Misses        843      843           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@t1m0thyj t1m0thyj added the no-changelog Add to PR's that don't require a CHANGELOG update label Nov 15, 2024
Copy link

github-actions bot commented Nov 15, 2024

📅 Suggested merge-by date: 12/2/2024

@t1m0thyj
Copy link
Member Author

There is another integration test (UpdateCredentials.feature) that has frequent transient failures, marking as draft until this one is fixed.

@t1m0thyj t1m0thyj marked this pull request as draft November 15, 2024 20:41
traeok
traeok previously approved these changes Nov 18, 2024
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me, thanks @t1m0thyj for the fix
Can re-approve if needed. The UpdateCredentials test is interesting because it tries to click on the search "action button" and Selenium times out stating that the search button isn't interactable.

Signed-off-by: Timothy Johnson <[email protected]>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 18, 2024
@t1m0thyj t1m0thyj marked this pull request as ready for review November 18, 2024 16:02
@t1m0thyj t1m0thyj requested a review from traeok November 18, 2024 16:02
traeok
traeok previously approved these changes Nov 18, 2024
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding Codicon handling to the QuickPick page object 😋

Signed-off-by: Timothy Johnson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update size/L
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants