-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload test results in CI when there are failing tests #3322
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Timothy Johnson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3322 +/- ##
=======================================
Coverage 92.99% 92.99%
=======================================
Files 116 116
Lines 12069 12069
Branches 2738 2737 -1
=======================================
Hits 11224 11224
Misses 843 843
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
📅 Suggested merge-by date: 12/2/2024 |
There is another integration test ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense to me, thanks @t1m0thyj for the fix
Can re-approve if needed. The UpdateCredentials test is interesting because it tries to click on the search "action button" and Selenium times out stating that the search button isn't interactable.
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding Codicon handling to the QuickPick
page object 😋
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Proposed changes
This is useful for debugging integration tests since we can download screenshots of failing tests 😋
Also fixes failing
npm audit
, and hopefully fixes transient errors in integration tests:ShowConfigErrorDialog
- since sometimes notifications are hidden in the notification center and other times they are still visible, it seems like we need to check both placesUpdateCredentials
- it seems more reliable to add profile via quick pick instead of expecting ZE to auto-detect a new default profileRelease Notes
Milestone: N/A
Changelog: N/A
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments