Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support gnome 3.30 #200

Merged
merged 1 commit into from
Oct 17, 2018
Merged

support gnome 3.30 #200

merged 1 commit into from
Oct 17, 2018

Conversation

jimmytheneutrino
Copy link
Contributor

See #197 for the issue.
Adapted as proposed by @smcv .
This contains just the bare minimum to support gnome 3.30. I did not modify any version info.

@kgizdov
Copy link

kgizdov commented Sep 21, 2018

seems to work for me in ArchLinux Gnome 3.30

@hedgepigdaniel
Copy link

Also on arch/gnome 3.30, works for me :)

@pabpas
Copy link

pabpas commented Sep 22, 2018

Fix works also on Debian testing/sid. Thanks!

@noghte
Copy link

noghte commented Sep 23, 2018

how can I compile and replace this fixed version with the installed extension?

@marty1885
Copy link

@noghte

git clone https://github.com/jimmytheneutrino/gnome-shell-extension-taskbar
cp -r gnome-shell-extension-taskbar/ ~/.local/share/gnome-shell/extensions/TaskBar@zpydr

Then login again.

@pabpas
Copy link

pabpas commented Sep 23, 2018

Small update after applying the fix. Now when clicking on an icon to minimize, Gnome crashes completely.

@jimmytheneutrino
Copy link
Contributor Author

@pabpas Could you provide more details? I could not reproduce the crash.

@marty1885
Copy link

@pabpas the code in the PR works for me. No crashes for any reason.

@pabpas
Copy link

pabpas commented Sep 24, 2018

Deleted the TaskBar folder and downloaded it again. No crashes so far.

@Taijian
Copy link

Taijian commented Sep 24, 2018

Also works for me, thanks for the patch!

@jimmytheneutrino
Copy link
Contributor Author

@zpydr Hey, it seems that people here love your work! Any chance you have in plans releasing version 58 with this (or similar) fix, some time soon?

@hashstat
Copy link

This is one of the most important extensions I use daily. After updating my Arch install it stopped working. :-( After applying the patch for this PR, all is good again. @zpydr Please find a few minutes to review and accept this PR. Thanks!

@santicalvo
Copy link

Works for me on Debian 3.30! As @hashstat , this extension is very important to me. Thanks very much!
I hope they release soon.

@marty1885
Copy link

@jimmytheneutrino Time to fork I guess?

Anyone here willing to maintain a fork? I might be able to update once a while. But I don't have time to add features. :(

@lsatenstein
Copy link

With Fedora and Gnome 3.3x Taskbar crashes if we use the tweaktool to enable/disable.
As well, if we invoke the settings and toggle any setting on or off (or try to center TB on the bottom ), a big CRASH.
But logging out and returning restores TB under Wayland. Alt-R does that under xorg.
repeat, its a Gnome 3.30 problem. I use Fedora 28, and the 3.28 Gnome and with 3.28, TB has never been an issue. The left-right adjustments and toggles do not crash TB.

@marty1885
Copy link

@lsatenstein It is caused by changes introduced in Gnome 3.29.3 that is only recently merged. I'm working on a workarround. But will take time. Gnome's documents aren't that great....

@zpydr zpydr merged commit da5d792 into zpydr:master Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.