Setting mode member of Filestream class #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have method mode() which returns open mode of current file but we never set mode variable.Thus it always return None.
|
Or as an another option we also can remove variable mode and method mode() P.S.Is it supposed that user can use FileStream or it is just for zasm internals needs? |
ZehMatt
approved these changes
Mar 28, 2024
|
Thanks, its not an internal thing, see tests.saverestore.cpp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have method mode() which returns open mode of current file but we never set mode variable.Thus it always return None.It seems that it simply was forgotten