Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added max_new_tokens as a config option to llm yaml block #1317

Merged
merged 6 commits into from
Nov 26, 2023

Conversation

gianniacquisto
Copy link
Contributor

Added max_new_tokens as a configuration option to the llm block in settings

Copy link
Contributor

Copy link
Contributor

@lopagela lopagela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value should be defined in the code. settings.yaml should not be modified.

Putting default values in settings.yaml is making the file settings.yaml consistantly growing, and will make the creation of custom configuration harder for users - which is why we should try to keep the definition of default values from there.

fern/docs/pages/manual/settings.mdx Outdated Show resolved Hide resolved
private_gpt/settings/settings.py Outdated Show resolved Hide resolved
private_gpt/settings/settings.py Outdated Show resolved Hide resolved
fern/docs/pages/manual/settings.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

Add default value for max_new_tokens = 256

Co-authored-by: lopagela <[email protected]>
Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

imartinez
imartinez previously approved these changes Nov 26, 2023
Copy link
Contributor

@lopagela lopagela merged commit 9c192dd into zylon-ai:main Nov 26, 2023
8 checks passed
simonbermudez pushed a commit to simonbermudez/saimon that referenced this pull request Feb 24, 2024
)

* added max_new_tokens as a configuration option to the llm block in settings

* Update fern/docs/pages/manual/settings.mdx

Co-authored-by: lopagela <[email protected]>

* Update private_gpt/settings/settings.py

Add default value for max_new_tokens = 256

Co-authored-by: lopagela <[email protected]>

* Addressed location of docs comment

* reformatting from running 'make check'

* remove default config value from settings.yaml

---------

Co-authored-by: lopagela <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants