Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default mode option to settings #2078

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Add default mode option to settings #2078

merged 4 commits into from
Sep 24, 2024

Conversation

basicbloke
Copy link
Contributor

@basicbloke basicbloke commented Sep 10, 2024 •
edited
Loading

Description

Add default mode to settings files

Type of Change

  • [*] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • [*] I stared at the code and made sure it makes sense
  • [*] Tested functionality within UI

Test Configuration:
Python: 3.11.9

Checklist:

  • [*] I have performed a self-review of my code
  • [*] My changes generate no new warnings

jaluma
jaluma requested changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@jaluma jaluma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments. Also, can you add this to settings.yaml?

private_gpt/settings/settings.py Show resolved Hide resolved
@basicbloke
Copy link
Contributor Author

need to run tests and fix

jaluma
jaluma requested changes Sep 11, 2024
View reviewed changes
settings.yaml Outdated Show resolved Hide resolved
jaluma
jaluma approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@jaluma jaluma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you!

@jaluma jaluma merged commit fa3c306 into zylon-ai:main Sep 24, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Sep 24, 2024
Open
@basicbloke basicbloke deleted the default-mode-setting branch September 24, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabloogc pabloogc pabloogc approved these changes

@jaluma jaluma jaluma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@basicbloke @jaluma @pabloogc